Галерея: сортировка по имени после пакетной загрузки - #643
Open
Ibochkarev wants to merge 2 commits into
Open
Conversation
After Uppy upload-complete, re-rank product gallery files by strnatcasecmp on name so numbered batches match ms2-style order without manual drag.
usort already reindexes the list; array_values was a no-op warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
После завершения пакетной загрузки в Uppy позиции файлов галереи пересчитываются natural sort по имени (
strnatcasecmpнаname, fallback наfile). Пакет01.jpg…10.jpgвстаёт в ожидаемый порядок без ручного drag-sort.Логика в
ProductImageService, тонкий процессорGallery/SortByName, вызов изProductGalleryнаupload-complete.Upload.phpи drag-sort (Sort.php) не менялись.Тип изменений
Связанные Issues
Refs #616 (только пункт 2 — Variant A: сортировка по имени). Компактный uploader и layout остаются вне этого PR.
Как это было протестировано?
composer test -- --filter ProductImageService, ESLint на изменённых Vue/JS)Конфигурация тестирования:
feat/issue-616-gallery-sort-by-nameСкриншоты (если применимо)
Чеклист
composer stan/ CI jobPHPStan)Дополнительные заметки
SortByNameтолько если есть успешные uploads. Очередь в одной вкладке сериализует overlappingcompleteприallowMultipleUploadBatches.product_id/parent_id = 0после загрузки может перезаписать предыдущий ручной drag-порядок (ожидаемое ms2-like поведение).gallerySortOnUpload), замена Uppy.Ручная проверка
01.jpg…10.jpg.