feat(vue): ModxManagerTheme и выравнивание UI менеджера - #640
Open
Ibochkarev wants to merge 13 commits into
Open
feat(vue): ModxManagerTheme и выравнивание UI менеджера#640Ibochkarev wants to merge 13 commits into
Ibochkarev wants to merge 13 commits into
Conversation
Manager SPA entries need the VueTools Import Map barrel that exports ModxManagerTheme; beta1 is too old for that contract.
Package version alone stays the same across vue-dist rebuilds, so browsers keep stale plugin tabs. Mix filemtime into the v= query when the module maps under assets_path.
Wire entries to the VueTools theme barrel, drop runtime form style injection, align MS3 tokens with theme primary, and reject primevue/* imports that duplicate Theme and break --p-* tokens.
Hide content_type on the product settings tab (force HTML) so friendly URIs do not pick up .css/.js. Tighten category options heading gap and load ActionsColumn CSS with the category Vue modules.
Theme panel spacing owns the inset; the old 20px style fought it.
Replace the Aura-era card grid with theme-aligned sections, clearer nav/resources hierarchy, and updated support copy.
Panel-based properties, vendor Select/filter copy, links empty state, gallery actions control, and chips that follow theme highlight tokens.
Migrate remaining PrimeVue imports to the barrel, drop size=small overrides so Normal density (36px) applies, use success CTAs, and localize order history log labels.
Idle drop zone is 168px and expands when files are queued or uploading. Disable singleFileFullScreen, keep the size note visible, and map Uppy accents to Modx primary/success tokens.
Align paginator/nav controls, tighten gallery edit and category filter layout, localize Uppy image-editor chrome, and keep boolean filters as Select.
Remove getSettingFields from product.common.js — not part of Modx theme UI work.
Ibochkarev
marked this pull request as ready for review
August 29, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Vue-менеджер MiniShop3 переведён на
ModxManagerThemeиз VueTools 1.1.3. Контролы 36px, primary CTA черезsuccess, отступы панелей по токенам темы.Дополнительно:
filemtime(после rebuild vue-dist вкладки не залипают на старом JS)primevue/*subpath-импортов в Vite (второй Theme ломал--p-*)Из PR убран форс
content_typeвproduct.common.js— к теме UI не относится. Локальный_build/config.inc.php(install => true) тоже не входит.Тип изменений
1.1.3-plвместо1.1.0-beta1Связанные Issues
Refs visual consistency вокруг manager theme (в т.ч. #615). Отдельного issue под весь пакет нет.
Как это было протестировано?
Локально на
resource/update(товар и категория),mgr/customers, Help, галерея Uppy, связи товара, grids заказов/настроек — послеnpm run buildи sync vue-dist.cd vueManager npm ci npm run lint:ci npm run buildПолный
composer ci:php/ PHPStan в этом прогоне не гонялись (PHP-дифф: cache-bust контроллеры, category CSS, мелкие правки фильтров).composer ci:php/composer test,npm run lint:ci,composer stan/ GitHub Actions CI)Конфигурация тестирования:
fix/mgr-modx-manager-theme-ui(1.13.0-beta1)Скриншоты (если применимо)
size=small/ Tailwind-blue accents#234368/ success CTAЧеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
Коммиты по слоям: VueTools bump → cache-bust → theme foundation → ExtJS/tpl → Help → product tabs → grids/forms → gallery Uppy → density polish → revert
product.common.js.Перед merge: VueTools ≥ 1.1.3 на стенде,
npm run buildдля vue-dist (каталог в gitignore).