fix(web-api): нормализация options в cart/add - #633
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
POST /api/v1/cart/add typed options as array and TypeError'd on form/JSON strings like "[]". Decode on the HTTP boundary and return 400 for non-array non-string values instead of 500.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
POST /api/v1/cart/addпадал с HTTP 500, еслиoptionsприходил строкой ("[]","{}",'{"color":"red"}'):CartControllerпередавал значение вCart::add(..., array $options)без нормализации, PHP бросал TypeError.Контроллер теперь принимает array или JSON-строку, декодирует через
CartItemManager::normalizeOptions(), а для прочих PHP-типов отвечает 400 (ms3_err_cart_options). Из демо-чанков убран hiddenvalue="[]". Штатныйms3.jsне менялся.Closes #632
Тип изменений
Связанные Issues
Closes #632
Как это было протестировано?
Локальный CI-гейт (без полной установки MODX/MySQL):
Vue не затронут. PHPStan локально не гонялся (нет
.phpstan-deps).composer ci:php/composer test)Конфигурация тестирования:
fix/issue-632-cart-add-options-stringСкриншоты (если применимо)
Не применимо (Web API).
Чеклист
composer stan/ CI jobPHPStan)Дополнительные заметки
Битый JSON (
"{bad") даёт пустые опции и 200, какnormalizeOptions()в домене. Невалидный PHP-тип (число, bool) — 400.changeOptionбез JSON-строк, как раньше.