Fixes Mojo alias highlighting in VS Code by post-processing semantic tokens returned from LSP server#214
Open
simutisernestas wants to merge 1 commit into
Open
Fixes Mojo alias highlighting in VS Code by post-processing semantic tokens returned from LSP server#214simutisernestas wants to merge 1 commit into
simutisernestas wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LSP currently resolves aliases like
Somefor hover, but emits them asvariablesemantic tokens. This patch reclassifiesvariabletokens astypeonly when they appear in syntactic type positions, such as:writer: Some[Writer]var x: MyAlias-> MyAliasstruct Foo(Copyable, Writable)A minimal regression test was added for the semantic-token correction behavior.
Note that, this is an extension-side workaround. The more correct long-term fix should likely live in
mojo-lsp-server, which has the semantic information needed to classify aliases directly as type-like semantic tokens instead ofvariable.