Conversation
|
Hi @samufi, thanks for submitting this! Looks like it is failing on line 11. I think You could probably sub out that line for |
carolinefrasca
left a comment
There was a problem hiding this comment.
Line 11 needs to be updated (see comment on PR)
|
Hmm, the issue seems to be that I require a Mojo version that is available on nightly only. In the Forum, it was suggested that I can specify the max-nightly requirement somewhere in the recipe, but I did not find anything else besides the place where the max version is specified. I'd welcome assistance. |
|
Hi @samufi, unfortunately adding this nightly breaks the Mosaic package – let me reach out to the owner and ask them to update their package, and then once that's done, I can add that nightly to the channel. |
|
@carolinefrasca I have updated Larecs to the second release, which uses the stable Mojo branch. Could you restart the checks so that we can see if the package can be merged? |
|
@samufi So sorry for the delay here – I totally missed this. This is the current error (looks like it's coming from one of your tests): |
|
@carolinefrasca I have updated Larecs and Mojo to the current stable release. Could you restart the testing procedure and see if it works now? |
|
@samufi seems like this is still failing due to one of the tests: |
Yes, @carolinefrasca, I have still not found the issue. Currently, I am waiting for a testing bug on nightly to be fixed so that I can see whether I can use some of the new features. I will message / tag you when there has been progress. |
|
Sounds good, thank you! |
|
@samufi checking in on this, have you had the opportunity to resolve the underlying issues? |
We have investigated this intensively, and @moseschmiedel has put an aweful lot of work into tracking down the issue down to the MLIR level. We are very certain this is a compiler bug (the MLIR code is wrong afawk), in particular one that occurs under We decided not to be blocked by the issue and will disable the failing tests, as we could never reproduce the issue under normal |
|
I flagged the post internally, and I'm hoping someone from the Mojo team will get back to you soon. |
* Bump mojo-regex to 0.10.0 * Pin mojo-regex 0.10.0 to NFAMatcher fix commit Updates the pinned rev to cbfdabc (msaelices/mojo-regex#98) so that the 0.10.0 release shipped through modular-community includes the `init_pointee_move` fix on `NFAMatcher`'s lazy DFA allocation. The previous rev (8e56a946) was main HEAD at the 0.10.0 version bump, before that fix landed. * Bump mojo-regex 0.10.0 rev to include hash-keyed cache fix Includes PR #99 (StringSlice pattern in public API with hash-keyed cache) and the CHANGELOG entry for PRs #98 and #99 in the 0.10.0 section. New pin: 6a8a0bd (main HEAD). * Bump mojo-regex 0.10.0 rev to pick up trimmed changelog * Update rev to include PR #102 (inline NFA range checks) * Update rev to include PR #102 changelog entry * Update rev to include PR #104 (precompute range classification) * Update rev to include PR #105 (eliminate get_pattern String copies) * Update rev to include PRs #103, #106 (re.sub + benchmarks) * Update rev to include PR #108 (capture group sub) * Update rev to include PR #110 (DFA fast path for sub) * Update rev to include PR #112 (optimize sub internals) * Update rev to include PR #113 (deep sub optimization) * Update rev to include PR #115 (SIMD LazyDFA first-byte filter) * Update rev to include PR #115 cleanup (remove dead scalar fallback) * Update rev to include PR #116 (extract shared nibble scan) * Update rev to include PRs #116, #117 and benchmark results * Update rev to include PR #118 (fix 3+ way alternation bug)

Add a recipe for the Larecs package
Logo could be a cone or twig of a larch tree (Larix decidua)
Checklist
recipe.yamlfile specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.0(for new packages, or if the version changed).