Skip to content

Fix for issue 432#433

Closed
petecarapetyan wants to merge 1 commit into
modernweb-dev:mainfrom
petecarapetyan:issue432
Closed

Fix for issue 432#433
petecarapetyan wants to merge 1 commit into
modernweb-dev:mainfrom
petecarapetyan:issue432

Conversation

@petecarapetyan

Copy link
Copy Markdown

What I did

  1. create a const for summary depending on whether menuNoLink as link or just text
  2. consume that value
  3. tested it to make sure it works (but not a regression test)

This Fix assumes that Issue 432 is even an issue. That may be the case, as it may be an intentional design. In which case ignore this fix.

@changeset-bot

changeset-bot Bot commented Sep 25, 2022

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0b0fd93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@daKmoR

daKmoR commented Jun 6, 2026

Copy link
Copy Markdown
Member

Thanks for the work on this.

Rocket has been rebuilt from a clean slate for the new @rocket/js soft launch. The old branch/PR history no longer applies to the current codebase, so I’m closing this as part of the repository reset.

This is not the full public relaunch yet. The package and docs are going live first so we can dogfood the new version on real projects, fix rough edges, and then follow up with a proper launch post, video, and release notes.

If this idea is still relevant for the new Rocket, please open a fresh issue or PR against the new main branch.

Thanks again for contributing.

@daKmoR daKmoR closed this Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants