fix: reopen root container across lifespan cycles#11
Merged
Conversation
The lifespan manager closed the root container at shutdown but never reopened it, so a second lifespan cycle against the same container (repeated test lifespans, server restarts) raised ContainerClosedError on the first request. Use `async with container:` so __aenter__ reopens on startup and __aexit__ closes on shutdown. Requires modern-di>=2.19.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The lifespan manager now wraps the root container in
async withso it reopens on each startup (__aenter__) and closes on shutdown (__aexit__), instead of only closing.Why
Previously
_lifespan_managerclosed the root container at shutdown but never reopened it. A second lifespan cycle against the same container — repeated test lifespans, or a server that restarts the lifespan — resolved on a closed root and raisedContainerClosedErroron the first request.Tests
tests/test_lifespan.pyruns twoTestClientcycles against the same app and asserts a request succeeds on the second cycle (and that the container is closed in between).Requires
modern-di>=2.19.0(floor bumped).🤖 Generated with Claude Code