refactor(ui): centralize extension review events

[benvinegar]

Summary

• publish extension review events through useExtensionReviewEvents
• preserve selection debouncing, file-view identity, event ordering, and initial filter, layout, and theme suppression
• prevent delayed callbacks from publishing to replaced or unmounted extension runtimes

Testing

• focused event publisher, lifecycle, StrictMode, and stale-timer tests
• relevant AppHost, command-authority, note-composer, and interaction tests
• PTY extension integration tests
• bun run typecheck
• bun run deps:check
• bun run lint
• targeted formatting and diff checks

Stack

• Builds on refactor(ui): isolate extension trust controller #876
• Followed by refactor(ui): isolate extension pane controller #881

This PR description was generated by Pi using GPT-5.6 Sol

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
hunk-web	Ignored	Preview	Aug 27, 2026 12:32pm

[greptile-apps]

Greptile Summary

This PR centralizes extension-facing review event publication in a dedicated hook while preserving debounce, initial-suppression, and runtime-retirement behavior.

• Moves selection, file-view, filter, layout, and theme effects out of App.
• Exposes stable publishers for watch, note, and command events.
• Adds focused coverage for runtime replacement, stale timers, soft reloads, unmounting, and StrictMode replay.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The refactor preserves existing event semantics while explicitly guarding delayed work across extension-runtime replacement and covering the relevant lifecycle behavior with focused tests.

Important Files Changed

Filename	Overview
src/ui/hooks/useExtensionReviewEvents.ts	Centralizes declarative and imperative extension review events with registry-aware baselines and stale-work retirement.
src/ui/App.tsx	Replaces inline extension event effects and callback wrappers with the centralized hook.
src/ui/hooks/useExtensionReviewEvents.test.tsx	Thoroughly exercises debounce, replacement, suppression, callback routing, unmount, and StrictMode behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  App[App review state and actions] --> Hook[useExtensionReviewEvents]
  Hook --> Declarative[Debounced and projected events]
  Hook --> Imperative[Stable action publishers]
  Declarative --> Runtime[Current extension runtime]
  Imperative --> Runtime
  Runtime --> Handlers[Extension event handlers]

Loading

_{Reviews (1): Last reviewed commit: "refactor(ui): centralize extension revie..." | Re-trigger Greptile}