refactor(ui): split mounted diff row views - #877
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThe PR refactors mounted diff-row rendering into focused code-row and metadata-row components while preserving the existing rendering facade and nested mouse-action ownership.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking need to move the new UI coverage into the repository’s required Storybook and Chromatic workflow. The rendering extraction preserves row dispatch, geometry inputs, cursor and selection paint, note controls, and shared mouse-event ownership; the only accepted concern is the test mechanism used for the new UI component. Files Needing Attention: src/ui/diff/CodeRowView.test.tsx Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[DiffRowView facade] --> B{Diff row type}
B -->|split-line or stack-line| C[CodeRowView]
B -->|collapsed or hunk-header| D[DiffMetaRowView]
C --> E[CodeCellView painting]
C --> F[rowMouseActions]
D --> F
F --> G[DiffPane parent mouse handling]
Prompt To Fix All With AI### Issue 1
src/ui/diff/CodeRowView.test.tsx:1
**Wrong UI test workflow**
This traditional Bun/OpenTUI component test bypasses the repository-required Storybook play test and Chromatic snapshot workflow, so the new component's visual coverage is not exercised through the standard visual-regression path.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "refactor(ui): split mounted diff row vie..." | Re-trigger Greptile |
9150ac2 to
343d6b6
Compare
Summary
CodeRowView.tsxDiffMetaRowView.tsxStack
Validation
bun run typecheckbun run lintbun run deps:checkThe unchanged local runtime-module resolver assertion remains the only environment-specific full-suite issue.
This PR description was generated by Pi using gpt-5.6-sol