fix(cli): reject partially numeric line and hunk values#535
Open
fallintoplace wants to merge 1 commit into
Open
fix(cli): reject partially numeric line and hunk values#535fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Contributor
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Number.parseInt() silently truncated malformed hunk and line values such as 12abc, 1.5, and 1e3. Validate the complete token as decimal digits and require the result to be a safe positive integer before accepting it.
This covers --hunk, --old-line, and --new-line and adds the required patch changeset.
Testing