fix(infer): validate explicit tool choices - #9871
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Return the intended validation error when an explicit tool choice does not exist in the request's tools list. Test: python tests/run.py --test_dir tests/infer --pattern test_protocol.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
An explicit
tool_choicecan name a function that is absent from therequest's
toolslist.ChatCompletionRequestMixinintended to report thisas a
ValueError, butnext()raisedStopIterationbefore the validationbranch could run.
This change gives
next()aNonedefault so the existing, actionable erroris raised:
Valid explicit choices retain the existing behavior of narrowing
toolstothe selected function. Automatic and disabled tool selection are unchanged.
Experiment results
Before:
After:
Verification: