Skip to content

add discord group#901

Merged
tastelikefeet merged 1 commit intomodelscope:mainfrom
tastelikefeet:feat/discord
Apr 15, 2026
Merged

add discord group#901
tastelikefeet merged 1 commit intomodelscope:mainfrom
tastelikefeet:feat/discord

Conversation

@tastelikefeet
Copy link
Copy Markdown
Collaborator

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
  • Documentation reflects the changes where applicable

@tastelikefeet tastelikefeet merged commit f491aaa into modelscope:main Apr 15, 2026
1 of 2 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md and README_ZH.md files to include a Discord Group link and QR code in the contact section. The review feedback suggests standardizing the Markdown table formatting by adding leading and trailing pipes for consistency and localizing the 'Discord Group' label in the Chinese documentation to match the existing '微信群' label.

Comment thread README.md
Comment on lines +50 to +52
[Discord Group](https://discord.gg/qmTFPY9byM) | WeChat Group
:-------------------------:|:-------------------------:
<img src="asset/discord_qr.jpg" width="200" height="200"> | <img src="asset/ms-agent.jpg" width="200" height="200">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The table formatting here is inconsistent with other tables in the document (e.g., the options table in the WebUI section), which use leading and trailing pipes. Adding them ensures consistent rendering and better adherence to the project's Markdown style.

Suggested change
[Discord Group](https://discord.gg/qmTFPY9byM) | WeChat Group
:-------------------------:|:-------------------------:
<img src="asset/discord_qr.jpg" width="200" height="200"> | <img src="asset/ms-agent.jpg" width="200" height="200">
| [Discord Group](https://discord.gg/qmTFPY9byM) | WeChat Group |
|:-------------------------:|:-------------------------:|
| <img src="asset/discord_qr.jpg" width="200" height="200"> | <img src="asset/ms-agent.jpg" width="200" height="200"> |

Comment thread README_ZH.md
Comment on lines +48 to +50
[Discord Group](https://discord.gg/qmTFPY9byM) | 微信群
:-------------------------:|:-------------------------:
<img src="asset/discord_qr.jpg" width="200" height="200"> | <img src="asset/ms-agent.jpg" width="200" height="200">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In the Chinese version of the README, it is more natural to translate "Discord Group" to "Discord 群" to match the "微信群" label. Additionally, adding pipes to the table maintains consistency with other tables in the document.

Suggested change
[Discord Group](https://discord.gg/qmTFPY9byM) | 微信群
:-------------------------:|:-------------------------:
<img src="asset/discord_qr.jpg" width="200" height="200"> | <img src="asset/ms-agent.jpg" width="200" height="200">
| [Discord ](https://discord.gg/qmTFPY9byM) | 微信群 |
|:-------------------------:|:-------------------------:|
| <img src="asset/discord_qr.jpg" width="200" height="200"> | <img src="asset/ms-agent.jpg" width="200" height="200"> |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants