support mtp_decoder_input_detach#37
Merged
Jintao-Huang merged 2 commits intomodelscope:mainfrom Apr 18, 2026
Merged
Conversation
Collaborator
Author
tastelikefeet
approved these changes
Apr 18, 2026
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration option mtp_decoder_input_detach to the ModelConfig and implements the corresponding logic in the MTP layer to detach decoder inputs when enabled. It also refactors the apply_module import to the module level for efficiency and improves the DSAIndexer patching logic in patcher.py by renaming classes to avoid name shadowing. I have no feedback to provide as the review comments were purely explanatory or validated the existing implementation.
hjh0119
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"mtp_decoder_input_detach": true,

"mtp_decoder_input_detach": false
