fix(server): parse Accept media types exactly#2481
Open
SnowSky1 wants to merge 1 commit into
Open
Conversation
Reject Streamable HTTP requests whose Accept values only contain the required media types as substrings, while preserving case-insensitive and parameterized values. Adds GET/POST regression coverage. Fixes modelcontextprotocol#2480. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9f897d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2480.
Summary
Streamable HTTP server
Acceptvalidation used raw substring checks, so values such asapplication/jsonxandtext/event-stream-bogusincorrectly satisfied the required concrete media types. This affected both POST negotiation and GET SSE requests.This change:
listsMediaTypehelper that parses the comma-separatedAcceptlist and compares media-type essences case-insensitively;This follows the same parsed-media-type approach recently applied to
Content-Typein #2441 / #2444, while keepingAccept-specific list parsing internal.Testing
pnpm --filter @modelcontextprotocol/core-internal test -- test/shared/mediaType.test.ts— 11 passingpnpm --filter @modelcontextprotocol/server test -- test/server/streamableHttp.test.ts— 50 passingpnpm --filter @modelcontextprotocol/core-internal check— cleanpnpm --filter @modelcontextprotocol/server check— clean