chore: update spec.types.ts from upstream#1888
Conversation
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — automated spec sync adding only JSDoc annotations, no type changes.
Extended reasoning...
Overview
This is the nightly automated sync of packages/core/src/types/spec.types.ts from the upstream MCP spec repo. The diff updates the source commit hash in the file header and adds two JSDoc annotations: @nullable on Task.ttl (which was already typed number | null) and @maxItems 100 on CompleteResult.completion.values (whose docstring already said "Must not exceed 100 items"). There are no changes to TypeScript types, exports, or runtime behavior.
Security risks
None. Comment-only changes in an auto-generated type definition file.
Level of scrutiny
Very low. This file is explicitly marked "DO NOT EDIT THIS FILE MANUALLY" and is regenerated by pnpm run fetch:spec-types via the nightly cron. The changes are purely documentation annotations that mirror constraints already expressed in the type signatures and prose. The spec.types.test.ts bidirectional assignability test would catch any actual type drift, and CI runs it.
Other factors
No changeset is included, which is appropriate since these JSDoc tags don't affect the published API surface or warrant a version bump on their own. No prior review comments to address.
github-actions
bot
force-pushed
the
update-spec-types
branch
from
0260b1b to
617875d
Compare
There was a problem hiding this comment.
LGTM — automated spec sync, JSDoc-only annotations.
Extended reasoning...
Overview
Automated nightly sync of packages/core/src/types/spec.types.ts from the upstream spec repo. The diff consists of (1) bumping the source-commit hash in the file header, (2) adding a @nullable JSDoc tag to Task.ttl, and (3) adding a @maxItems 100 JSDoc tag to CompleteResult.completion.values. No TypeScript types, signatures, or exports change.
Security risks
None. Comment-only additions in a generated type-definitions file; no runtime code, no I/O, no auth surface.
Level of scrutiny
Very low. This file is explicitly auto-generated ("DO NOT EDIT THIS FILE MANUALLY"), the PR is produced by the nightly cron, and the changes are pure JSDoc annotations that mirror constraints already stated in the prose docstrings (null for unlimited, Must not exceed 100 items). Per the repo's spec-sync workflow (#1886, #1866), these PRs are routine and intended to be merged without ceremony.
Other factors
No changeset is needed since there is no observable API/behavior change. The bug-hunting system found nothing. spec.types.test.ts bidirectional checks are unaffected because no structural types changed.
github-actions
bot
force-pushed
the
update-spec-types
branch
from
617875d to
5d4f19c
Compare
There was a problem hiding this comment.
LGTM — automated spec sync, JSDoc annotations only.
Extended reasoning...
Overview
Automated nightly sync of packages/core/src/types/spec.types.ts from the upstream spec repo. The diff updates the source-commit hash in the header and adds two JSDoc annotations: @nullable on Task.ttl and @maxItems 100 on CompleteResult.completion.values. No TypeScript type signatures change — these are doc-comment hints consumed by JSON-schema generators, and both merely formalize constraints already stated in the surrounding prose.
Security risks
None. Comment-only changes in a generated type-declaration file; no runtime code, no auth, no I/O.
Level of scrutiny
Very low. This file is explicitly marked "DO NOT EDIT MANUALLY" and is regenerated by pnpm run fetch:spec-types via a cron job. The repo treats these PRs as routine mechanical updates. The actual TS types (number | null, string[]) are unchanged, so downstream Zod schemas and spec.types.test.ts are unaffected.
Other factors
No changeset is included, which is appropriate — JSDoc-only additions don't warrant a version bump. No prior reviewer comments to address.
github-actions
bot
force-pushed
the
update-spec-types
branch
from
5d4f19c to
2917471
Compare
There was a problem hiding this comment.
LGTM — automated spec sync adding JSDoc annotations only.
Extended reasoning...
Overview
Automated nightly spec-sync PR updating packages/core/src/types/spec.types.ts from the upstream MCP spec repo. The diff bumps the source commit hash in the header and adds two JSDoc annotations: @nullable on Task.ttl (already typed number | null) and @maxItems 100 on CompleteResult.completion.values (already documented in prose as max 100). No TypeScript type signatures change.
Security risks
None. Comment-only additions to a generated types file; no runtime code, no auth, no I/O.
Level of scrutiny
Low. This is a bot-generated mechanical sync of a file explicitly marked "DO NOT EDIT THIS FILE MANUALLY". The added annotations are schema-generation hints that match the existing TypeScript types and prose exactly, so there is no drift to flag.
Other factors
No changeset is needed since the public API surface is unchanged. No prior human or bot review comments to address. The bug-hunting system found nothing.
|
Reopening to trigger CI (bot-created PRs don't fire pull_request workflows). |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
There was a problem hiding this comment.
LGTM — automated spec sync adding JSDoc annotations only.
Extended reasoning...
Overview
This is the nightly automated sync of packages/core/src/types/spec.types.ts from the upstream MCP spec repo. The diff bumps the source-commit hash in the file header and adds two JSDoc annotations: @nullable on Task.ttl and @maxItems 100 on CompleteResult.completion.values. No TypeScript types, field shapes, or exports change — these are comment-only additions that already match the existing prose and type signatures (number | null, "Must not exceed 100 items").
Security risks
None. There is no executable logic, no schema validation change, and no API surface change — only JSDoc tag additions in a generated types file.
Level of scrutiny
Very low. This file is explicitly auto-generated ("DO NOT EDIT THIS FILE MANUALLY") and the PR is the routine cron-driven sync. The changes are purely documentation annotations that mirror constraints already stated in the surrounding doc text and types, so there is no behavioral or compatibility impact. spec.types.test.ts bidirectional checks would catch any actual type drift, and CI was retriggered by a maintainer.
Other factors
No changeset is needed since nothing user-visible changes (no version bump warranted for comment-only edits). No prior reviewer comments are outstanding. The bug-hunting system found nothing.
1 participant
This PR updates
packages/core/src/types/spec.types.tsfrom the Model Context Protocol specification.Source file: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/5c25208be86db5033f644a4e0d005e08f699ef3d/schema/draft/schema.ts
This is an automated update triggered by the nightly cron job.