feat(client): support custom claims in PrivateKeyJwtProvider#1875
Open
JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
feat(client): support custom claims in PrivateKeyJwtProvider#1875JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Expose the existing `claims` parameter from `createPrivateKeyJwtAuth` in the `PrivateKeyJwtProviderOptions` interface, allowing custom claims to be included in the JWT client assertion. This enables enterprise scenarios where additional claims (e.g., tenant_id) help scope the access token with finer granularity than scopes alone, without requiring clients to manage JWT signing directly. Closes modelcontextprotocol#1477
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the existing
claimsparameter fromcreatePrivateKeyJwtAuthin thePrivateKeyJwtProviderOptionsinterface, allowing custom claims to be included in the JWT client assertion.Closes #1477
Motivation
Enterprise deployments often need additional claims in the client assertion JWT (e.g.,
tenant_id,role) to scope the access token with finer granularity than scopes alone allow. Currently, users must either:StaticPrivateKeyJwtProviderand manage JWT signing themselves (addingjoseas a direct dependency and re-implementing audience discovery)addClientAuthenticationfunctionSince
createPrivateKeyJwtAuthalready supports aclaimsparameter internally, this change simply threads it throughPrivateKeyJwtProviderOptions— minimal surface area change with significant usability improvement.Changes
packages/client/src/client/authExtensions.ts:claims?: Record<string, unknown>toPrivateKeyJwtProviderOptionsclaimsthrough tocreatePrivateKeyJwtAuthin the constructorpackages/client/test/client/authExtensions.test.ts:createPrivateKeyJwtAuthPrivateKeyJwtProviderTest plan
pnpm build:all)pnpm typecheck:all)pnpm lint:all)AI Disclosure
AI assistance (Claude) was used for issue research. The implementation was written and reviewed by the author.