fix:close transport on connection failure

[sid293]

Fixes a resource leak on connection failure and resolves TypeScript error in packages/client/test/client/auth.test.ts.

Motivation and Context

client.ts: Moved super.connect() inside the try block so the catch block can properly close the transport if initialization fails.

auth.test.ts: Added as unknown as RequestInit to resolve a type mismatch on the optional cache property.

How Has This Been Tested?

Added a new integration test to verify that the transport is closed even when startup fails.
All tests were verified passing using the workspace-wide command: pnpm test:all

Breaking Changes

none

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

[changeset-bot]

⚠️ No Changeset found

Latest commit: 511c1a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@1862

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@1862

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@1862

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@1862

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@1862

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@1862

commit: 511c1a1

[felixweinberger]

Hi @sid293 thanks for this - did you come across this in something you were working on or is this purely speculative based on reading the source?

Some context for how you ran into this issue would be great.

[felixweinberger]

If we need this type assertion to make this work, that's a sign the solution isn't quite there yet.

[sid293]

• regarding the connect() change, I came across while using the library, when connection failed to connect it was not automatically closed and saw some comments saying maybe it should.

• regarding the type assertion, I was getting red underline on my editor for cache.

and I thought of writing something like this:

declare global {
    type RequestCache = "default" | "force-cache" | "no-cache" | "no-store" | "only-if-cached" | "reload";

    interface RequestInit {
        cache?: RequestCache;
    }
}

but looking a bit more I found out it was because my editor's typescript version was not updated and maybe in previous versions cache was not included in RequestInit type.

sorry I will revert back to previous commit