fix: preserve internal error message when decoding from a peer#248
Closed
systemblueio wants to merge 1 commit into
Closed
fix: preserve internal error message when decoding from a peer#248systemblueio wants to merge 1 commit into
systemblueio wants to merge 1 commit into
Conversation
MCPError's decoder dropped the message for code -32603 by passing nil as
the detail fallback, while every other standard JSON-RPC error case falls
back to the message. A peer sending {"code":-32603,"message":"..."} with
no data.detail decoded to .internalError(nil), losing the message. Use the
message fallback so internalError matches the other cases.
Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Superseded by #249 (same fix, cleaner commit history). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
MCPError's decoder dropped the message for-32603. That case passednilas the detail fallback, whileparseError,invalidRequest,methodNotFound, andinvalidParamsall fall back to themessage. So a peer sending{"code":-32603,"message":"..."}with nodata.detaildecoded to.internalError(nil), losing the message that the other standard errors keep.Fix
One line:
-32603now usesunwrapDetail(message), matching the other standard JSON-RPC error cases.Verification
Added a decode test in
ResponseTeststhat fails onmainand passes with the change. Full suite green (swift test, 552 tests).