fix: fill missing fully qualified syntax in prompt_handler macros#866
Open
moroviintaas wants to merge 1 commit into
Open
fix: fill missing fully qualified syntax in prompt_handler macros#866moroviintaas wants to merge 1 commit into
moroviintaas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some syntax generated by macro
#[prompt_handler]was not fully qualified.I needed to
usethem in my user code, so the macro does not break. This include:rmcp::model::GetPromptResultrmcp::modelListPromptsResultrmcp::model::PaginatedRequestParamsrmcp::RoleServerrmcp::service::RequestContextHow Has This Been Tested?
examples/servers/src/common/counter.rs, removing imports fromrmcp- fully qualified broken idents in examples.Breaking Changes
This commit probably does not introduce braking changes.
I haven't changed macros that use
McpError, which is then imported in examples withrmcp::ErrorData as McpError.Types of changes
Checklist
Additional context
It seems there are still some macro code that forces user to import:
but I am not sure if fixing it would not be a breaking change.