fix(macros): respect local feature in #[prompt] macro — omit + Send bound#803
Open
WeekendSuperhero wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
local feature in #[prompt] macro — omit + Send bound
DaleSeo
reviewed
Apr 10, 2026
| match &fn_item.sig.output { | ||
| syn::ReturnType::Default => { | ||
| quote! { -> ::std::pin::Pin<Box<dyn ::std::future::Future<Output = ()> + Send + #lt>> } | ||
| if omit_send { |
Member
There was a problem hiding this comment.
omit_send isn't defined, so it won't compile!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #801
The
#[tool]macro correctly omits+ Sendon generated handler futures when thelocalcrate feature is enabled (tool.rs:341). The#[prompt]macro was not updated whenlocalsupport was added in #740 — it unconditionally emits+ Sendon all generated futures (prompt.rs:141,144).This makes it impossible to use
!Sendtypes in prompt handlers even with thelocalfeature enabled, despite tool handlers working correctly. The real-world use case is MCP servers wrapping platform APIs with thread-affine types (e.g., Apple EventKit'sEKEventStore).How Has This Been Tested?
cargo test --workspace)Rc<String>(!Send) with both#[tool]and#[prompt]handlers compiles withfeatures = ["local"]after this change (previously only#[tool]compiled)Breaking Changes
None. This only changes behavior when the
localfeature is explicitly enabled. Default behavior (withoutlocal) is unchanged —+ Sendis still emitted.Types of changes
Checklist
Additional context
The fix mirrors the existing pattern in
tool.rs:339-341:Applied the same
cfg!(feature = "local")check toprompt.rsfor bothReturnType::DefaultandReturnType::Typematch arms.