feat(server): carry structured input-validation details in tool error results - #3422
Conversation
… results When MCPServer rejects arguments against a tool's input schema, the CallToolResult flattened pydantic's ValidationError into a single text line, so clients had to regex prose to tell a wrong type from a missing required field (modelcontextprotocol#3351). Attach structured_content to that specific error result: a stable input_validation code plus per-error path/type/message. The rejected values stay out of the payload, the text content the model reads is unchanged, and clients only revalidate structured content of successful results, so no output-schema check is affected.
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3351. If a maintainer assigns you to #3351, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Issue
Fixes #3351 (as realized on the current v2 server; the issue's snippet predates the mcpserver refactor).
Summary
When
MCPServerrejects arguments against a tool's input schema, theCallToolResultflattened pydantic'sValidationErrorinto a single text line, so clients had to regex prose to tell a wrong type from a missing required field — with message wording that varies per validator keyword and is not a stable contract.For that specific failure mode, the error result now also carries machine-readable details in
structured_content:{ "type": "input_validation", "errors": [ {"path": "x", "type": "int_parsing", "message": "..."} ] }structured_contentof successful results (Client.call_tool→validate_tool_resultis gated onnot result.is_error).Testing
pytest tests/server/mcpserver/test_server.py— 168 passed, including two new tests: one asserting the structured details (path/type/message, and that rejected values are not echoed), one asserting deliberateToolErrors still carry no structured content (backward compat).ruff check/ruff format --checkon both touched files — clean.