fix: submit current JSON tool parameters#1726
Draft
hogeheer499-commits wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #988. If a user edits a JSON-only parameter and immediately clicks Run Tool or Open App, the editor can still be inside its 300 ms debounce window. The previous code validated the current text but submitted the older React state.
The validation step now returns the value it just parsed, and both submission paths use that value directly. Invalid JSON remains blocked.
Type of Change
Testing
The regressions edit a JSON object and submit before the debounce fires, then assert that Tools and Apps both receive the new object.
npm test, client lint, and the client build pass. The E2E suite passes on Chromium and Firefox (16/16); WebKit cannot start on this host becauselibevent,libavif, andlibwoffare unavailable.Checklist
npm run prettier-fix)Breaking Changes
None.
Additional Context
I used AI tooling during investigation and test preparation, then reviewed the final diff and test output.