Skip to content

mcp: avoid double-copy of payload in writeEvent #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yarolegovich merged 2 commits into from
Jul 24, 2026
+6 −1
Merged

mcp: avoid double-copy of payload in writeEvent #1106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0061a33
mcp: avoid double-copy of payload in writeEvent
george1410 Jun 3, 2026
c302d9c
Merge branch 'main' into incident-io/writeevent-no-double-copy
yarolegovich Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mcp/event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,12 @@ func writeEvent(w http.ResponseWriter, evt Event) (int, error) {
if evt.Retry != "" {
fmt.Fprintf(&b, "retry: %s\n", evt.Retry)
}
fmt.Fprintf(&b, "data: %s\n\n", string(evt.Data))
// Write the payload directly into a pre-grown buffer to avoid the extra
// copy from string(evt.Data) and repeated buffer regrowths.
b.Grow(len("data: \n\n") + len(evt.Data))
b.WriteString("data: ")
b.Write(evt.Data)
b.WriteString("\n\n")
n, err := w.Write(b.Bytes())
rc := http.NewResponseController(w)
// Ignore returned error as flushing is best-effort.
Expand Down
Loading