Allow switch port timeout to be configured#272
Merged
Conversation
Previously we would timeout switch ports after 300s of inactivity. Ideally active connections would be configured to send keep-alive packets sooner than this. To better support cases with no keep-alives, it's useful to be able to reconfigure the idle timeout (e.g. to make it much bigger). This patch adds - a command-line argument `--port-max-idle-time` - a database key `slirp/port-max-idle-time` which allow the default 300s to be overriden. Related to moby#235 Related to moby#234 Signed-off-by: David Scott <dave.scott@docker.com>
This allows us to completely disable the mechanism by setting the port-max-idle-time to 0 (or -ve) Signed-off-by: David Scott <dave.scott@docker.com>
Previously using a text editor might result in a string like `1\n` which would be rejected. This patch trims the unnecessary whitespace from the beginning and end of ints and bools so this string will be parsed as `1`. Signed-off-by: David Scott <dave.scott@docker.com>
|
How do you set this value on Docker for Windows? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would timeout switch ports after 300s of inactivity. Ideally active connections would be configured to send keep-alive packets sooner than this. To better support cases with no keep-alives, it's useful to be able to reconfigure the idle timeout (e.g. to make it much bigger or disable it altogether).
This patch adds
--port-max-idle-timeslirp/port-max-idle-timewhich allow the default 300s to be overriden. Values
<= 0disable the timeout mechanism completely.Related to #235
Related to #234