Make avdevice library optional again#1246
Open
dimula73 wants to merge 1 commit into
Open
Conversation
ddennedy
approved these changes
May 11, 2026
Member
ddennedy
left a comment
ddennedy
left a comment
There was a problem hiding this comment.
working for me with avdevice included 👍
Contributor
|
Making the dependency optional is in principle fine for me, but I would prefer to have it explicitly managed with a |
jlskuz
requested changes
May 18, 2026
It is not used by avformat when performing playback via SDL2, the only thing it does is initializing avdevice and not using it later.
dimula73
force-pushed
the
kazakov/make-avdevice-optional
branch
from
b41eb38 to
516b077
Compare
Contributor
Author
|
Hi, @jlskuz! I have applied your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not used by avformat when performing playback via SDL2, the only thing it does is initializing avdevice and not using it later.
This is a follow-up of the previous rejected MR: #1239