Skip to content

Fix for problems indexing date_range in non-compliant EAD files - #68

Open
rshiggin wants to merge 2 commits into
mainfrom
arc-160-date-range-scope
Open

Fix for problems indexing date_range in non-compliant EAD files#68
rshiggin wants to merge 2 commits into
mainfrom
arc-160-date-range-scope

Conversation

@rshiggin

@rshiggin rshiggin commented Aug 10, 2026

Copy link
Copy Markdown
Member

Top chunk in each changed file is for EAD files that conform to spec (e.g., bhl XML includes @normal with date_range). Bottom chunk parses XML that is out of spec. For the most part, these are tweaked queries ported from production. Tested in dev with bhl, clements, and scrc.

@rshiggin
rshiggin requested a review from ssciolla August 13, 2026 17:02
@rshiggin
rshiggin marked this pull request as ready for review August 13, 2026 17:02
@rshiggin

Copy link
Copy Markdown
Member Author

CI failures are

  • rubocop wants double-quotes in regex strings. I don't think adding additional escape backslashes to satisfy rubocop is a good practice. We could change .yml config so that double quotes instring literals are not required.
  • brakeman gem has new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant