Add contents hierarchy to collection display (ARC-149) by ssciolla · Pull Request #67 · mlibrary/boxwalker

ssciolla · 2026-08-06T21:58:37Z

To Do

Add Contents to sidebar navigation
Add Aeonform functionality - see inventory of Aeon code in umich, especially aeonform.js https://mlit.atlassian.net/browse/ARC-161
Fix navbar styling
Investigate wrapping of Javascript (IIFE) (can we remove it?) Yes. With current modules method not necessary, but good to have for standalone js.
Finalize JS loading pipeline
Fix strong parameters? (Determined no action was needed. The log message is originating from the below line and just is designed to filter out unneeded parameters before it goes to the search_service. The log message will go away in production.)
- https://github.com/projectblacklight/arclight/blob/105af73da603b337b1f8fa54d76103f34e98350a/app/models/concerns/arclight/catalog.rb#L41
- https://api.rubyonrails.org/classes/ActionController/Parameters.html
```
Unpermitted parameters: :contents, :key, :paginate. Context: { controller: CatalogController, action: hierarchy, request: #<ActionDispatch::Request:0x0000000126c232c0>, params: {"contents" => "true", "key" => "-document", "paginate" => "true", "controller" => "catalog", "action" => "hierarchy", "id" => "umich-bhl-032"} }
```
Tidy up show more/ show less (truncation control shows even when it's not needed).
Fix indentation
Make sure box info is showing up in Contents hierarchy (added this manually. Looks like maybe we could use document actions?)
Make interesting(?) items links (items are linked always right now, no counter is in use)
According to the Claude analysis is_interesting items are linked. Counter is not enabled on label-only items.
- What's the deal with counters?
  Blacklight uses the counter option in link_to_document for search session tracking. When it's supplied:
  - The generated link includes tracking data with the counter value
  - Clicking through to a record lets Blacklight record which position in the results the user clicked.
  - It powers features on the show page like "« Previous | 123 of 456 | Next »" navigation
Auto-expand item with checkbox whenever an item has only one child
Requests should be EAD-specific, but persist across collections during session (aeonform.js)
Search results should default to "Grouped by collection"

…on page

…use blended; tidy up a couple things

… in contents hierarchy; add container_types to component EAD config; add needed methods to SolrDocument

…her event listener method

…tmap and applications.js, not via manifest.js

…r true

…/less button

…g SolrDocument methods

… using document actions, for now); make extent data look more like it does in search results

…pages

rshiggin

Great work!

…iv, etc.

ssciolla · 2026-08-14T16:27:24Z

+class NokogiriXpathExtensions
+  def is_component(node_set)
+    node_set.find_all do |node|
+      component_elements = (1..12).map { |i| "c#{'%02d' % i}" }
+      component_elements.push "c"
+      component_elements.include? node.name
+    end
+  end
+end
+
+to_field "child_component_count_isi" do |record, accumulator|
+  accumulator << record.xpath("/ead/archdesc/dsc/*[is_component(.)]", NokogiriXpathExtensions.new).count
+end


We needed to add this for the root document, but the ead_component_config has something similar for components using | between all the possible cX values. I wonder if it's possible to do something like that here, but not going to worry about it right now.

…n, parses EAD ID from data-document-id= string value before _aspace

…atalog/item-id

… format matching umich-arclight

…lected count in aeonform

Copilot

Pull request overview

Adds a navigable collection contents hierarchy with Aeon item-request selection and updated collection-page navigation.

Changes:

Adds expandable contents hierarchy, breadcrumbs, and sidebar links.
Indexes child counts and container types for hierarchy behavior.
Adds session-persisted Aeon selections and request metadata.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`lib/um_arclight/traject/ead2_config.rb`	Indexes top-level child counts.
`lib/um_arclight/traject/ead2_component_config.rb`	Indexes component container types.
`config/importmap.rb`	Pins Aeon and truncation JavaScript.
`app/views/catalog/hierarchy.html.erb`	Selects the contents hierarchy renderer.
`app/views/arclight/requests/_aeon_hidden_form_request.html.erb`	Adds Aeon JavaScript hooks.
`app/models/solr_document.rb`	Adds hierarchy and Aeon metadata helpers.
`app/javascript/arclight/truncate_controller.js`	Detects whether content is truncated.
`app/javascript/application.js`	Loads Aeon functionality.
`app/javascript/aeonform.js`	Persists and submits Aeon selections.
`app/helpers/um_arclight_helper.rb`	Determines component linkability.
`app/controllers/catalog_controller.rb`	Configures breadcrumbs and metadata.
`app/components/um_document_component.html.erb`	Adds breadcrumbs and contents hierarchy.
`app/components/um_contents_document_collection_hierarchy_component.rb`	Defines hierarchy presentation behavior.
`app/components/um_contents_document_collection_hierarchy_component.html.erb`	Renders hierarchy entries and controls.
`app/components/um_collection_sidebar_component.html.erb`	Adds Contents and Access navigation.
`app/components/um_breadcrumbs_hierarchy_component.rb`	Limits breadcrumbs to components.
`app/components/um_breadcrumbs_hierarchy_component.html.erb`	Renders component ancestry.
`app/components/um_aeon_request_checkbox_component.rb`	Defines Aeon checkbox component.
`app/components/um_aeon_request_checkbox_component.html.erb`	Renders request metadata inputs.
`app/assets/stylesheets/application.scss`	Loads contents styling.
`app/assets/stylesheets/_search_results.scss`	Removes obsolete truncator styling.
`app/assets/stylesheets/_contents.scss`	Styles hierarchy and request controls.
`app/assets/stylesheets/_collection.scss`	Updates toolbar and breadcrumb styling.
`app/assets/stylesheets/_base.scss`	Adds sticky toolbar positioning.

Suppressed comments (1)

app/models/solr_document.rb:108

This returns the raw multivalued Solr array, so interpolation into the hidden input serializes it with Ruby array syntax (for example, ["Restricted"]) rather than as usable Aeon item information. Join the values before exposing them as a form value.

  def aeon_item_info_1_value
    accessrestrict
  end

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

rshiggin · 2026-08-17T19:49:40Z

+    <input type="hidden" name="ItemSubTitle_<%= document.id %>" value="<%= document.aeon_item_sub_title_value %>">
+    <input type="hidden" name="ItemVolume_<%= document.id %>" value="<%= document.aeon_item_volume_value %>">
+    <input type="hidden" name="ItemCitation_<%= document.id %>" value="<%= document.aeon_item_citation_value %>">
+    <input type="hidden" name="ItemInfo1" value="<%= document.aeon_item_info_1_value %>">


We copied line 8 as it was in original from umich-arclight.
<input type="hidden" name="ItemInfo1" value="<%= document.aeon_item_info_1_value %>">

ssciolla · 2026-08-17T18:10:46Z

+    <li class="nav-item">
+      <%= link_to "Contents",
+                  "#{document_path}#contents",
+                  class: 'nav-link pl-0 ps-0 py-1',
+                  data: { turbolinks: 'false' }
+      %>
+    </li>


This made sense on first glance, but on testing, things are still working, i.e. they send the user back to the Contents of the root document. This seems to be because of the logic in the sidebar component here: https://github.com/projectblacklight/arclight/blob/105af73da603b337b1f8fa54d76103f34e98350a/app/components/arclight/collection_sidebar_component.rb#L32

…ierarchy; join extent chunks in aeon field

…tch and console message in case of storage write errors

…s with field_config field names

rshiggin reviewed Aug 10, 2026

View reviewed changes

Comment thread app/javascript/aeonform.js

ssciolla added the enhancement New feature or request label Aug 11, 2026

ssciolla force-pushed the arc-149-contents branch from 34f8449 to e36a141 Compare August 11, 2026 21:03

ssciolla and others added 21 commits August 13, 2026 14:22

Add work-in-progress on displaying contents hierarchy on the collecti…

0253355

…on page

Add Contents (in wrong place to sidebar list); make icon placeholder …

20829e5

…use blended; tidy up a couple things

Fix positoning of Contents in sidebar navigation

abf055a

Add aeonform.js to application

634b608

Updated and modernized aeonform.js

93cd8a9

Delete old version and location of aeonform.js

2704d6d

Revise include_tag in base.html.erb based on Claude recommend

1fd1418

restore application.js

98d285d

Rubocop linting

0e8750c

Introduce UmAeonRequestCheckboxComponent and move into component card…

e8b7928

… in contents hierarchy; add container_types to component EAD config; add needed methods to SolrDocument

Add event listener for clear; convert onclick shim for submit to anot…

385e64e

…her event listener method

Fix styling for request navbar

701933c

Switch aeonform.js to use the 'modules' method for loading, via impor…

13eb2db

…tmap and applications.js, not via manifest.js

Simplify abstract_or_scope method in contents component using accesso…

27138ea

…r true

Add custom arclight/truncate_controller.js to stabilize abstract more…

7d68b70

…/less button

Increase indent on checkbox items

0d9a260

Reintroduce is_interesting_component? helper method, adding supportin…

f9b7d9f

…g SolrDocument methods

Fix Rubocop offenses of single-quoted strings

f2fdcca

Add containers manually to contents hierarchy components (rather than…

5937d5d

… using document actions, for now); make extent data look more like it does in search results

Shaded background for single-item metadata above contents

8da4f99

Add back paginated Contents for nested component pages

a343356

ssciolla force-pushed the arc-149-contents branch from b450e1b to a343356 Compare August 13, 2026 18:25

Switch to using the hierarchy with checkboxes for component document …

b3736ee

…pages

ssciolla commented Aug 13, 2026

View reviewed changes

Comment thread app/components/um_contents_document_collection_hierarchy_component.html.erb Outdated

rshiggin and others added 2 commits August 13, 2026 16:10

Centering checkbox in requests hierarchy

45ff63a

Tidy up _contents.scss to remove duplicates

a2ace1b

ssciolla commented Aug 13, 2026

View reviewed changes

Comment thread app/components/um_contents_document_collection_hierarchy_component.html.erb Outdated

ssciolla requested a review from rshiggin August 13, 2026 21:05

rshiggin approved these changes Aug 13, 2026

View reviewed changes

ssciolla added 3 commits August 13, 2026 17:07

Do some tidying up; remove show_expanded? usages

6eea393

Tidy up contents component, removing unused classes, an unnecessary d…

df588c5

…iv, etc.

Auto-expand when component only has one child

0a52d5c

ssciolla commented Aug 14, 2026

View reviewed changes

rshiggin and others added 5 commits August 14, 2026 15:00

Modify to keep requests EAD-specific, checked items persist in sessio…

79c699f

…n, parses EAD ID from data-document-id= string value before _aspace

Sidebar nav item links build correctly with document_path added for c…

ad1682d

…atalog/item-id

Ports breadcrumbs-component into collection display above title, with…

c5fce41

… format matching umich-arclight

Refactor breadcrumbs hierachy component; change hidden text around se…

f57cbbd

…lected count in aeonform

Remove extra newline at EOF

ecc1f6b

ssciolla marked this pull request as ready for review August 17, 2026 17:07

ssciolla requested a balanced review from Copilot August 17, 2026 17:08

Copilot started reviewing on behalf of ssciolla August 17, 2026 17:08 View session

Copilot AI reviewed Aug 17, 2026

View reviewed changes

ssciolla and others added 4 commits August 17, 2026 15:37

Use li elements (with some overridden background style) in contents h…

06e668a

…ierarchy; join extent chunks in aeon field

Per Copilot suggestions, changed unique ID to idno value and added ca…

6c67b2e

…tch and console message in case of storage write errors

Fix is_interesting_component logic to correctly compare skippable key…

8a33f9a

…s with field_config field names

Fix some indentation; add a newline at EOF

602115d

ssciolla merged commit 968f514 into main Aug 17, 2026
4 of 5 checks passed

Navigation Menu

Uh oh!

Add contents hierarchy to collection display (ARC-149) - #67

Add contents hierarchy to collection display (ARC-149)#67
ssciolla merged 36 commits into
mainfrom
arc-149-contents

ssciolla commented Aug 6, 2026 •

edited by rshiggin

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rshiggin left a comment

Uh oh!

ssciolla Aug 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

rshiggin Aug 17, 2026

Uh oh!

Uh oh!

Uh oh!

ssciolla Aug 17, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ssciolla commented Aug 6, 2026 • edited by rshiggin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rshiggin left a comment

Choose a reason for hiding this comment

Uh oh!

ssciolla Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

rshiggin Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ssciolla Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ssciolla commented Aug 6, 2026 •

edited by rshiggin

Loading