leak global CommandEncoder -- avoid cuda synchronize on process shutdown - #4480
Merged
Conversation
- used in mlx-swift - global CommandEncoder are still alive after exit even if no work is happening - the destructor tries to call cuda api, which causes a fatal error
davidkoski
commented
Sep 8, 2026
Comment on lines
+620
to
+623
| // encoders are leaked intentionally as they would synchronize on process | ||
| // shutdown | ||
| static auto* encoders = new std::unordered_map<int, CommandEncoder>(); | ||
| return *encoders; |
Member
Author
There was a problem hiding this comment.
Per internal discussion we decided leaking these on process exit was ok. I was able to test this on a cuda device with mlx-swift.
davidkoski
commented
Sep 8, 2026
Comment on lines
615
to
616
| static thread_local std::unordered_map<int, CommandEncoder> encoders; | ||
| return encoders; |
Member
Author
There was a problem hiding this comment.
I don't know if this has the same issue -- mlx-swift doesn't use the TLS Streams, but since the python code does, perhaps it is ok.
zcbenz
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from