Document Pi Witan setup and target isolation#8
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the docs/agent-memory.md documentation to introduce "Named targets for destination isolation," which helps users keep work and personal agent memories separate. It includes configuration instructions for ~/.config/witan/config.toml, updates MCP server setups for Claude Code and Pi to use WITAN_TARGET, and details Pi extensions. The review feedback highlights a few improvements: ensuring the ~/.pi/agent/extensions/ directory is created before symlinking, removing a stray code block fence, and cleaning up unnecessary vertical whitespace inside several code blocks to improve rendering.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ln -sf \ | ||
| "$REPO/configs/pi/extensions/codegraph.ts" \ | ||
| ~/.pi/agent/extensions/ | ||
| ln -sf \ | ||
| "$REPO/configs/pi/extensions/workflow-context.ts" \ | ||
| ~/.pi/agent/extensions/ |
There was a problem hiding this comment.
If the ~/.pi/agent/extensions/ directory does not already exist, the ln commands will fail or behave unexpectedly. Adding mkdir -p ~/.pi/agent/extensions/ beforehand ensures the directory exists and the symlinks are created correctly.
| ln -sf \ | |
| "$REPO/configs/pi/extensions/codegraph.ts" \ | |
| ~/.pi/agent/extensions/ | |
| ln -sf \ | |
| "$REPO/configs/pi/extensions/workflow-context.ts" \ | |
| ~/.pi/agent/extensions/ | |
| mkdir -p ~/.pi/agent/extensions/ | |
| ln -sf \ | |
| "$REPO/configs/pi/extensions/codegraph.ts" \ | |
| ~/.pi/agent/extensions/ | |
| ln -sf \ | |
| "$REPO/configs/pi/extensions/workflow-context.ts" \ | |
| ~/.pi/agent/extensions/ |
| | **`memory_update` tool** | Expose `update_memory` query as a first-class tool. v1 workaround: `memory_get` + `memory_store`. | | ||
| | **`link_supersedes` / `link_applies_to` tools** | Expose edge mutations so agents can express relationships between memories without the CLI. | | ||
| | **`memory_delete` tool** | Requires a separate `delete.gq` file (D₂ constraint: cannot mix deletes with inserts/updates). Deliberately omitted to prevent accidental data loss in v1. | | ||
|
|
There was a problem hiding this comment.
There is a stray closing code block fence ``` on line 1598 that has no matching opening fence. Additionally, this newly added empty line on line 1597 is unnecessary. Please remove both the empty line and the stray closing fence on line 1598.
| used in this session: | ||
|
|
||
| ``` | ||
|
|
There was a problem hiding this comment.
Adding empty lines at the very beginning and end of code blocks (as seen here and in several other places in this file, e.g., lines 1484, 1487, 1495, 1499, etc.) introduces unnecessary vertical whitespace inside the rendered code blocks. It is cleaner to remove these empty lines so the code blocks render with standard padding.
|
Did you try the |
2 participants
What are the relevant tickets?
N/A
Description (What does it do?)
How can this be tested?
uvx prek run --all-files.git diff --check.Additional Context
The target isolation behavior was introduced in #5. This PR documents the setup path for that feature, especially for Pi users.