Optimize single element find#827
Open
mvorisek wants to merge 2 commits into
Open
Conversation
mvorisek
force-pushed
the
optimize_single_find
branch
from
e44c723 to
f160d71
Compare
mvorisek
force-pushed
the
optimize_single_find
branch
from
f160d71 to
91314b2
Compare
mvorisek
force-pushed
the
optimize_single_find
branch
from
d604a66 to
2a6eff2
Compare
Contributor
Author
|
please help with adjusting the tests |
aik099
reviewed
Apr 27, 2022
Member
|
@mvorisek you need to update the tests of |
Contributor
Author
Yes, I tried to do so, but the assertions are written using mocked objects and I do not know how to fix them. Can you please help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no BC break, no functionality change
improve performance with large sites with wide locators