MILAB-6648: require a changeset for every edited package, in one gate

[AStaroverov]

What

require-package-path-bump now enforces both halves of the release contract under a single check
(check for changesets):

1. require-package-bump — the package at package-path must be bumped directly, on every PR,
   whether or not its own files changed.
2. check-coverage — every other workspace package whose own files the PR edits must be
   bumped too.

The separate always-green changeset coverage (diagnostic) job is gone; coverage now runs as a
second step inside check for changesets. No new input, no new check name.

Why

The coverage check already existed, but ran with continue-on-error: true and an explicit
"keep this job out of required checks" note. A red result cost nothing and nobody had to act on it,
so a PR could edit a package and merge with that package shipping new content under an unchanged
version.

Why both halves rather than one

Neither half implies the other, so replacing the first with the second would have weakened the
gate:

• require-package-bump ignores the diff — it demands a package-path bump on every PR.
• check-coverage ignores untouched packages, and skips private ones.

In a block repo only block is published; model / ui / workflow / test are private: true.
A PR editing only ui/ is therefore invisible to coverage, while require-package-bump correctly
fails it. Both steps run and both must pass.

Half 2 only starts to bite in a repo with more than one publishable package.

The second step runs under !cancelled(), so one red check reports the complete set of missing
bumps instead of one per run.

Empty changeset

pnpm changeset --empty waived require-package-bump but not coverage, so an author declaring
"no release needed" was passed by one half and failed by the other. check-coverage.sh now honours
the same opt-out, waiving every missing package at once.

Scoped to changesets added in the branch: an empty changeset inherited from the base branch must
not disable the gate for every branch cut after it.

The rule is duplicated rather than extracted into a shared file — there is no bash-sharing
precedent between actions in this repo (lib/ holds TypeScript packages), and refactoring the
working, tested require-package-bump.sh was not worth the risk. Both copies state the rule in
place and say so.

Behaviour of the coverage half

require-package-path-bump	event	coverage runs	blocks merge
off — every consumer today	any	no	—
on	pull_request	yes	yes
on	merge_group	no	—
on	pull_request + skip-changelog label	job skipped	—

With the toggle off, check for changesets behaves exactly as before — non-blocking on PRs,
blocking on the merge queue and push-to-default. What those repos give up is the never-actionable
diagnostic check.

changeset-coverage was in no other job's needs, so build/test and the Slack release notification
are unaffected either way.

Tests

actions/changeset/check-coverage/test/coverage.bats — six cases added: the waiver applies; it
waives several packages at once; it waives alongside a partial real changeset; an inherited empty
changeset does not waive; a non-empty changeset is not read as the opt-out; exit 2 (tooling broken)
still wins over the waiver. 21/21 pass.

require-package-bump.bats untouched, 9/9.

Not in this PR

• Turning it on. No consumer passes require-package-path-bump yet. The structurer template
  that generates every block's build.yaml (block-tools, build.tpl.yaml) can pass it once this
  is on v4.
• Branch protection. A failing job blocks merge only once check for changesets is a required
  check in the consuming repo's settings.
• Canary run. Refs inside this branch are @v4, so a consumer pointed at the branch still
  resolves the nested uses: to stable v4. The new step cannot be exercised from a consumer PR
  until this merges.

Greptile Summary

The PR consolidates direct package-bump and edited-package coverage enforcement into the existing check for changesets gate, while allowing branch-added empty changesets to waive both requirements.

• Changeset: release metadata describing package version bumps; this PR recognizes an empty changeset as a branch-scoped declaration that no release is needed.
• Package-path bump: a direct bump for the package selected by package-path; this remains mandatory on opted-in pull requests unless the gate is waived.
• Changeset coverage: the requirement that every edited, publishable workspace package be represented in the release set; this moves from a non-blocking diagnostic job into the main gate.
• Publishable package: a non-private workspace package eligible for release; private packages remain excluded from coverage.
• Release gate: the check for changesets job that now enforces both release-contract halves under one check.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
.github/workflows/node-simple-pnpm.yaml	Folds edited-package coverage into the opt-in pull-request changeset gate and removes the separate diagnostic job.
actions/changeset/check-coverage/action.yaml	Documents the branch-added empty-changeset waiver and the action's git-history requirement.
actions/changeset/check-coverage/check-coverage.sh	Detects newly added empty changesets after determining missing package bumps and waives the coverage failure when one is present.
actions/changeset/check-coverage/test/coverage.bats	Adds coverage for waiver scope, multiple missing packages, mixed changesets, inherited opt-outs, and tooling failures.
actions/changeset/check-coverage/test/helpers.bash	Adds a fixture helper that commits the canonical empty-changeset form.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  PR[Pull request] --> Toggle{require-package-path-bump?}
  Toggle -- No --> Existing[Run existing changeset status check]
  Toggle -- Yes --> Label{skip-changelog label?}
  Label -- Yes --> Skip[Skip changeset gate]
  Label -- No --> Direct[Require direct package-path bump]
  Direct --> Coverage[Run edited-package coverage unless cancelled]
  Coverage --> Empty{Branch-added empty changeset?}
  Empty -- Yes --> Waive[Waive missing package bumps]
  Empty -- No --> Compare[Compare edited publishable packages with releases]
  Compare --> Result{All required packages bumped?}
  Result -- Yes --> Pass[Gate passes]
  Result -- No --> Fail[Gate fails]

Loading

_{Reviews (2): Last reviewed commit: "MILAB-6707: fold changeset coverage into..." | Re-trigger Greptile}

Context used:

• Context used - Terms is a types in codebase. Provide the list of ... (source)

[notion-workspace]

[infra] Automatic ‘block’ version bumps on changes to ui/wf/model/test

[notion-workspace]

[project-templates] Implementation