fix: resolve daily CI build failures (1ES pool image + npm auth)#999
Open
ramsessanchez wants to merge 7 commits into
Open
fix: resolve daily CI build failures (1ES pool image + npm auth)#999ramsessanchez wants to merge 7 commits into
ramsessanchez wants to merge 7 commits into
Conversation
Add missing 'image' property to 1ES pool config and configure npm registry auth via .npmrc and npmAuthenticate task for network isolation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ramsessanchez
had a problem deploying
to
build_test
GitHub Actions
Failure
ramsessanchez
had a problem deploying
to
build_test
GitHub Actions
Failure
Aligns with updated approach from core PR - creates .npmrc via script step during pipeline execution rather than checking it into the repo. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace hardcoded Azure Artifacts registry URL with npmRegistryUrl pipeline variable, matching the approach in msgraph-sdk-typescript-core. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the NPM_REGISTRY_URL pipeline variable directly instead of mapping through an env block. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the 3-step .npmrc creation, npmAuthenticate, and npm ci script with a single npm@1 task using customRegistry/customFeed, matching the pattern from microsoftgraph/msgraph-sdk-typescript-core#583. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…mrc-with-npm-task chore: replace .npmrc creation with npm@1 task in daily CI build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the daily CI build pipeline which was failing due to two issues:
1. Missing
imageproperty in pool configThe 1ES Pipeline Templates require
name,image, andosto all be specified. The main pool was missing theimageproperty, causing:Fix: Added
image: ubuntu-latestto the main pool configuration.2. npm registry auth for network isolation
Under 1ES network isolation policies, direct access to
registry.npmjs.orgis blocked, causing:Fix:
.npmrcinline at build time (not committed to the repo) pointing to theGraphDeveloperExperiences_PublicAzure Artifacts feednpmAuthenticate@0task beforenpm ciin the pipelineThis approach avoids committing an
.npmrcto the repo, which would break the GitHub Actions workflow that authenticates directly againstregistry.npmjs.org.