Skip to content

Weekly Permissions sync 2026-04-18#1504

Open
marabooy wants to merge 1 commit intomasterfrom
permissions-update/2026-04-18
Open

Weekly Permissions sync 2026-04-18#1504
marabooy wants to merge 1 commit intomasterfrom
permissions-update/2026-04-18

Conversation

@marabooy
Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2026-04-18

@marabooy marabooy requested a review from a team as a code owner April 18, 2026 00:29
Copilot AI review requested due to automatic review settings April 18, 2026 00:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Weekly permissions sync updating the generated permission metadata used by the repo’s permissions/new/* datasets.

Changes:

  • Added new permission definitions for CopilotPolicySettings.Read and CopilotPolicySettings.ReadWrite (including path mappings).
  • Updated provisioningInfo.json deployments with new/updated permission variants (Copilot policy settings, InfoProtect ABAC policy permissions, cross-tenant policy read, and several privileged schedule/policy entries).
  • Adjusted existing policy/authentication-related path mappings (e.g., CrossTenantAccessPolicy GET handling, authentication method configuration additions, and FIDO2/passkey path mapping updates).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
permissions/new/provisioningInfo.json Updates permission deployment variants (IDs, hidden flags, and newly introduced permission entries).
permissions/new/permissions.json Adds Copilot policy settings permissions and updates various policy/authentication path mappings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +8189 to +8192
"InfoProtectABACPolicy.Read.All": [
{
"id": "f8c4e3f1-6b9a-4c2e-8d5a-bcf123456789",
"scheme": "DelegatedWork",
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added InfoProtectABACPolicy.* permission keys (and their array entries) are mis-indented compared to the surrounding permissionDeployments entries (keys elsewhere align at 4 spaces, array items at 6). Please reformat these blocks to match the file’s established 2-space indentation so diffs stay clean and automated formatting/validation doesn’t drift.

Copilot uses AI. Check for mistakes.
Comment on lines +11055 to +11068
"id": "",
"scheme": "DelegatedWork",
"environment": "public",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000002-0000-0000-c000-000000000000"
},
{
"id": "",
"scheme": "Application",
"environment": "public",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000002-0000-0000-c000-000000000000"
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Policy.Read.CrossTenantAccess is configured with resourceAppId = 00000002-0000-0000-c000-000000000000, but the existing Policy.ReadWrite.CrossTenantAccess entry in this same file uses resourceAppId = "". Since both permissions are for CrossTenantAccess policies, this looks like an inconsistent resource target and will likely break provisioning/lookup. Please align resourceAppId with the correct resource (matching the ReadWrite permission unless there’s a documented reason to differ).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants