Batch action list width measurements#326642
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0c897748-1cc7-4982-afbd-13377eb136a5
Contributor
There was a problem hiding this comment.
Pull request overview
Batches action-list width measurements to reduce layout thrashing while preserving toolbar accounting and row styles.
Changes:
- Groups width writes, geometry reads, and restoration into phases.
- Adds regression coverage for ordering, toolbar width, and restoration.
Show a summary per file
| File | Description |
|---|---|
actionList.ts |
Adds batched row-width measurement helper. |
actionList.test.ts |
Tests batching and width calculations. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
lszomoru
approved these changes
Jul 20, 2026
Contributor
Author
|
@sandy081 merging to get more selfhosting time in. We can revert if you don't like the change when you're back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
Chromium CDP instrumentation over 49 representative rows and 200 measurement passes:
Measured row widths were identical.
Validation
npm run typecheck-client -- --pretty false./scripts/test.sh --run src/vs/platform/actionWidget/test/browser/actionList.test.tsnpm run valid-layers-checknpm run precommitFixes #326640
cc @sandy081