Tool Approval Management: the approval cannot be selected again after being deselected.

[alexr00]

Fixes #306416

[github-actions]

Screenshot Changes

Base: 8b5518b0 Current: 3d9780ac

Changed (1)

agentSessionsViewer/ApprovalRowLongLabel/Light

Before	After

[Copilot]

Pull request overview

This PR targets the “Manage Tool Approval” quick tree in chat, aiming to address an interaction where a tool approval could not be selected again after being deselected (Issue #306416).

Changes:

• Adds filtering to omit tool nodes that are unchecked and have no children in the server-scoped tool list.
• Adds the same filtering to omit unchecked/no-children tool nodes in the non-server tool list.

Show a summary per file

File	Description
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsConfirmationService.ts	Filters out unchecked tools without children from the quick tree items (both server and non-server sections).

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/tools/languageModelToolsConfirmationService.ts:873

• Same issue here: skipping tools when checked === false && toolChildren.length === 0 hides tools that are eligible for approvals but currently not approved. This breaks the ability to (re)enable approvals from the "Manage Tool Approval" quick tree because the item is removed as soon as it is unchecked.

				// Skip tools with no active approvals and no children
				if (checked === false && toolChildren.length === 0) {
					continue;
				}

• Files reviewed: 1/1 changed files
• Comments generated: 1