Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce re-creation of chat tool progress UI parts by caching and updating an existing ChatProgressContentPart instance during tool streaming/progress updates in the chat widget.
Changes:
- Cache a
ChatProgressContentPartin the tool streaming subpart and update it viaupdateMessage(...)instead of recreating it. - Cache a
ChatProgressContentPartin the tool progress subpart and update it viaupdateMessage(...)instead of recreating it.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolStreamingSubPart.ts | Reuses a single progress content part while tool invocation is in streaming state, updating message content in place. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolProgressPart.ts | Reuses a single progress content part for tool progress rendering, updating message content in place. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
...contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolStreamingSubPart.ts
Outdated
Show resolved
Hide resolved
...nch/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolProgressPart.ts
Show resolved
Hide resolved
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.