fix: clear GitHub remote source cache when session changes#308927
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: clear GitHub remote source cache when session changes#308927yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When a user signs out of their GitHub account, the cached repository list in GithubRemoteSourceProvider persists, allowing previously linked repos to still appear in the clone dialog. Similarly, the module-level Octokit instance is never invalidated on session change. This fix: - Adds a clearOctokitCache() function and calls it from OctokitService when GitHub sessions change - Makes GithubRemoteSourceProvider listen to authentication session changes and clear userReposCache when the GitHub session is removed - Properly disposes the session change listener Fixes microsoft#164868
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GithubRemoteSourceProviderlisten toauthentication.onDidChangeSessionsand resetuserReposCacheso previously linked repos no longer appear in the clone dialog after sign-outTest plan
Fixes #164868