fix: remove dead CSS referencing undefined inlineChat.regionHighlight#308926
Open
yogeshwaran-c wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: remove dead CSS referencing undefined inlineChat.regionHighlight#308926yogeshwaran-c wants to merge 2 commits intomicrosoft:mainfrom
yogeshwaran-c wants to merge 2 commits intomicrosoft:mainfrom
Conversation
The source location annotation (e.g. 'repl:1') in the debug console output was included in native text selections, causing it to appear in copied text when selecting across multiple output lines. Add user-select: none to the .source element so the source annotation is excluded from text selection while remaining visible and clickable. Fixes microsoft#275702
…hlight variable The `inlineChat.regionHighlight` theme color was removed when the old inline chat implementation was cleaned up, but three CSS rules in notebookCellChat.css still referenced the `--vscode-inlineChat-regionHighlight` CSS variable. These rules targeted classes (inline-chat-block-selection, inline-chat-diff-widget, inline-chat-newfile-widget) that are no longer applied by any TypeScript code, making them dead code. Remove the three dead CSS rules and the stale entry from vscode-known-variables.json. Fixes microsoft#229281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #229281
The
inlineChat.regionHighlighttheme color was removed when the old inline chat implementation was cleaned up (in #286503), but three CSS rules innotebookCellChat.cssstill referenced the--vscode-inlineChat-regionHighlightCSS variable. These rules targeted classes (inline-chat-block-selection,inline-chat-diff-widget,inline-chat-newfile-widget) that are no longer applied by any TypeScript code, making them dead code.notebookCellChat.cssthat reference the undefined variable--vscode-inlineChat-regionHighlightentry fromvscode-known-variables.jsonTest plan
./scripts/test-documentation.shor the stylelint check and verify noUnknown variable: --vscode-inlineChat-regionHighlightwarnings