fix: exclude source annotations from text selection in debug console#308925
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: exclude source annotations from text selection in debug console#308925yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The source location annotation (e.g. 'repl:1') in the debug console output was included in native text selections, causing it to appear in copied text when selecting across multiple output lines. Add user-select: none to the .source element so the source annotation is excluded from text selection while remaining visible and clickable. Fixes microsoft#275702
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repl:1) being included in clipboard text when selecting and copying multi-line output from the Debug Consoleuser-select: noneto the.sourceelement in the REPL tree so the annotation is excluded from native text selections while remaining visible and clickableRoot cause
The REPL tree enables text selection on
.monaco-tl-contentsviauser-select: text. The source annotation (rendered bySourceWidgetas a.sourceelement) lives inside the same flex container (.value-and-source) as the output value. When a user selects text across multiple output lines, the browser's native selection includes the source annotation text, causing strings likerepl:1to appear in the pasted result.Test plan
console.log('hello \n there')hello \n therewithoutrepl:1insertedFixes #275702