[WIP] Complete package manager command class refactoring

package.json

@@ -144,6 +144,156 @@
                     "description": "%python-envs.packageWatchers.description%",
                     "default": true,
                     "scope": "machine"
+                },
+                "python-envs.packageManager.installCommandArgs": {
+                    "type": "object",
+                    "markdownDescription": "%python-envs.packageManager.installCommandArgs.description%",
+                    "scope": "machine",
+                    "properties": {
+                        "verboseOutput": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.installCommandArgs.verboseOutput.description%",
+                            "default": false
+                        },
+                        "retryOnFailure": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.installCommandArgs.retryOnFailure.description%",
+                            "default": true
+                        },
+                        "maxRetries": {
+                            "type": "integer",
+                            "description": "%python-envs.packageManager.maxRetries.description%",
+                            "default": 1,
+                            "minimum": 0,
+                            "maximum": 3
+                        }
+                    },
+                    "additionalProperties": false
+                },
+                "python-envs.packageManager.uninstallCommandArgs": {
+                    "type": "object",
+                    "markdownDescription": "%python-envs.packageManager.uninstallCommandArgs.description%",
+                    "scope": "machine",
+                    "properties": {
+                        "verboseOutput": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.uninstallCommandArgs.verboseOutput.description%",
+                            "default": false
+                        },
+                        "retryOnFailure": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.uninstallCommandArgs.retryOnFailure.description%",
+                            "default": true
+                        },
+                        "maxRetries": {
+                            "type": "integer",
+                            "description": "%python-envs.packageManager.maxRetries.description%",
+                            "default": 1,
+                            "minimum": 0,
+                            "maximum": 3
+                        }
+                    },
+                    "additionalProperties": false
+                },
+                "python-envs.packageManager.listCommandArgs": {
+                    "type": "object",
+                    "markdownDescription": "%python-envs.packageManager.listCommandArgs.description%",
+                    "scope": "machine",
+                    "properties": {
+                        "verboseOutput": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.listCommandArgs.verboseOutput.description%",
+                            "default": false
+                        },
+                        "retryOnFailure": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.listCommandArgs.retryOnFailure.description%",
+                            "default": true
+                        },
+                        "maxRetries": {
+                            "type": "integer",
+                            "description": "%python-envs.packageManager.maxRetries.description%",
+                            "default": 1,
+                            "minimum": 0,
+                            "maximum": 3
+                        }
+                    },
+                    "additionalProperties": false
+                },
+                "python-envs.packageManager.versionCommandArgs": {
+                    "type": "object",
+                    "markdownDescription": "%python-envs.packageManager.versionCommandArgs.description%",
+                    "scope": "machine",
+                    "properties": {
+                        "verboseOutput": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.versionCommandArgs.verboseOutput.description%",
+                            "default": false
+                        },
+                        "retryOnFailure": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.versionCommandArgs.retryOnFailure.description%",
+                            "default": true
+                        },
+                        "maxRetries": {
+                            "type": "integer",
+                            "description": "%python-envs.packageManager.maxRetries.description%",
+                            "default": 1,
+                            "minimum": 0,
+                            "maximum": 3
+                        }
+                    },
+                    "additionalProperties": false
+                },
+                "python-envs.packageManager.availableVersionsCommandArgs": {
+                    "type": "object",
+                    "markdownDescription": "%python-envs.packageManager.availableVersionsCommandArgs.description%",
+                    "scope": "machine",
+                    "properties": {
+                        "verboseOutput": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.availableVersionsCommandArgs.verboseOutput.description%",
+                            "default": false
+                        },
+                        "retryOnFailure": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.availableVersionsCommandArgs.retryOnFailure.description%",
+                            "default": true
+                        },
+                        "maxRetries": {
+                            "type": "integer",
+                            "description": "%python-envs.packageManager.maxRetries.description%",
+                            "default": 1,
+                            "minimum": 0,
+                            "maximum": 3
+                        }
+                    },
+                    "additionalProperties": false
+                },
+                "python-envs.packageManager.listDirectNamesCommandArgs": {
+                    "type": "object",
+                    "markdownDescription": "%python-envs.packageManager.listDirectNamesCommandArgs.description%",
+                    "scope": "machine",
+                    "properties": {
+                        "verboseOutput": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.listDirectNamesCommandArgs.verboseOutput.description%",
+                            "default": false
+                        },
+                        "retryOnFailure": {
+                            "type": "boolean",
+                            "description": "%python-envs.packageManager.listDirectNamesCommandArgs.retryOnFailure.description%",
+                            "default": true
+                        },
+                        "maxRetries": {
+                            "type": "integer",
+                            "description": "%python-envs.packageManager.maxRetries.description%",
+                            "default": 1,
+                            "minimum": 0,
+                            "maximum": 3
+                        }
+                    },
+                    "additionalProperties": false
                 }
             }
         },

package.nls.json

@@ -47,5 +47,24 @@
     "python-envs.runPetInTerminal.title": "Run Python Environment Tool (PET) in Terminal...",
     "python-envs.managePackageVersion.title": "Manage Package Version",
     "python-envs.alwaysUseUv.description": "When set to true, uv will be used to manage all virtual environments if available. When set to false, uv will only manage virtual environments explicitly created by uv.",
-    "python-envs.packageWatchers.description": "When enabled, file system watchers monitor site-packages for install/uninstall changes and automatically refresh the package list. Disable this if you experience performance issues in large workspaces."
+    "python-envs.packageWatchers.description": "When enabled, file system watchers monitor site-packages for install/uninstall changes and automatically refresh the package list. Disable this if you experience performance issues in large workspaces.",
+    "python-envs.packageManager.installCommandArgs.description": "Arguments and settings for the install command (pip/uv install).",
+    "python-envs.packageManager.uninstallCommandArgs.description": "Arguments and settings for the uninstall command (pip/uv uninstall).",
+    "python-envs.packageManager.listCommandArgs.description": "Arguments and settings for the list command (pip/uv list).",
+    "python-envs.packageManager.versionCommandArgs.description": "Arguments and settings for the version command (pip/uv --version).",
+    "python-envs.packageManager.availableVersionsCommandArgs.description": "Arguments and settings for the availableVersions command (pip index versions).",
+    "python-envs.packageManager.listDirectNamesCommandArgs.description": "Arguments and settings for the listDirectNames command (pip list --not-required).",
+    "python-envs.packageManager.maxRetries.description": "Maximum number of retry attempts (0-3).",
+    "python-envs.packageManager.installCommandArgs.verboseOutput.description": "Display full output from the install command.",
+    "python-envs.packageManager.installCommandArgs.retryOnFailure.description": "Retry the install command once on failure.",
+    "python-envs.packageManager.uninstallCommandArgs.verboseOutput.description": "Display full output from the uninstall command.",
+    "python-envs.packageManager.uninstallCommandArgs.retryOnFailure.description": "Retry the uninstall command once on failure.",
+    "python-envs.packageManager.listCommandArgs.verboseOutput.description": "Display full output from the list command.",
+    "python-envs.packageManager.listCommandArgs.retryOnFailure.description": "Retry the list command once on failure.",
+    "python-envs.packageManager.versionCommandArgs.verboseOutput.description": "Display full output from the version command.",
+    "python-envs.packageManager.versionCommandArgs.retryOnFailure.description": "Retry the version command once on failure.",
+    "python-envs.packageManager.availableVersionsCommandArgs.verboseOutput.description": "Display full output from the availableVersions command.",
+    "python-envs.packageManager.availableVersionsCommandArgs.retryOnFailure.description": "Retry the availableVersions command once on failure.",
+    "python-envs.packageManager.listDirectNamesCommandArgs.verboseOutput.description": "Display full output from the listDirectNames command.",
+    "python-envs.packageManager.listDirectNamesCommandArgs.retryOnFailure.description": "Retry the listDirectNames command once on failure."
 }

src/managers/base/commands/availableVersions.ts

@@ -0,0 +1,22 @@
+import { BaseExecuteArgs, PackageManagerCommand } from './packageManagerCommand';
+
+/**
+ * Arguments for available versions command execution (change per execution).
+ */
+export interface AvailableVersionsExecuteArgs extends BaseExecuteArgs {
+    packageName: string;
+    pythonVersion: string;
+    includePrerelease?: boolean;
+}
+
+/**
+ * Template class for availableVersions commands.
+ * Subclasses implement concrete package-manager-specific logic.
+ */
+export abstract class AvailableVersionsCommand extends PackageManagerCommand {
+    protected static readonly configSection = 'availableVersionsCommandArgs';
+
+    protected abstract buildCommand(executeArgs: AvailableVersionsExecuteArgs): string[];
+
+    abstract execute(executeArgs: AvailableVersionsExecuteArgs): Promise<string[]>;
+}

src/managers/base/commands/index.ts

@@ -0,0 +1,7 @@
+export { AvailableVersionsCommand, type AvailableVersionsExecuteArgs } from './availableVersions';
+export { InstallCommand, type InstallExecuteArgs } from './install';
+export { ListCommand } from './list';
+export { ListDirectNamesCommand } from './listDirectNames';
+export { BaseExecuteArgs, CommandConstructorOptions, PackageManagerCommand } from './packageManagerCommand';
+export { UninstallCommand, type UninstallExecuteArgs } from './uninstall';
+export { VersionCommand } from './version';

src/managers/base/commands/install.ts

@@ -0,0 +1,21 @@
+import { BaseExecuteArgs, PackageManagerCommand } from './packageManagerCommand';
+
+/**
+ * Arguments for install command execution (change per execution).
+ */
+export interface InstallExecuteArgs extends BaseExecuteArgs {
+    packages: { packageName: string; version?: string }[];
+    upgrade?: boolean;
+}
+
+/**
+ * Template class for install commands.
+ * Subclasses implement concrete package-manager-specific logic.
+ */
+export abstract class InstallCommand extends PackageManagerCommand {
+    protected static readonly configSection = 'installCommandArgs';
+
+    protected abstract buildCommand(executeArgs: InstallExecuteArgs): string[];
+
+    abstract execute(executeArgs: InstallExecuteArgs): Promise<void>;
+}

src/managers/base/commands/list.ts

@@ -0,0 +1,12 @@
+import { PackageInfo } from '../../../api';
+import { BaseExecuteArgs, PackageManagerCommand } from './packageManagerCommand';
+
+/**
+ * Template class for list commands.
+ * Subclasses implement concrete package-manager-specific logic.
+ */
+export abstract class ListCommand extends PackageManagerCommand {
+    protected static readonly configSection = 'listCommandArgs';
+
+    abstract execute(executeArgs?: BaseExecuteArgs): Promise<PackageInfo[]>;
+}

src/managers/base/commands/listDirectNames.ts

@@ -0,0 +1,11 @@
+import { BaseExecuteArgs, PackageManagerCommand } from './packageManagerCommand';
+
+/**
+ * Template class for listDirectNames commands.
+ * Subclasses implement concrete package-manager-specific logic.
+ */
+export abstract class ListDirectNamesCommand extends PackageManagerCommand {
+    protected static readonly configSection = 'listDirectNamesCommandArgs';
+
+    abstract execute(executeArgs?: BaseExecuteArgs): Promise<string[]>;
+}

src/managers/base/commands/packageManagerCommand.ts

@@ -0,0 +1,76 @@
+import { CancellationToken, l10n, LogOutputChannel, ProgressLocation, window, WorkspaceConfiguration } from 'vscode';
+import { getConfiguration } from '../../../common/workspace.apis';
+
+/**
+ * Base interface for all command execute arguments.
+ * Provides optional cancellation token that all commands can use.
+ */
+export interface BaseExecuteArgs {
+    cancellationToken?: CancellationToken;
+    showProgress?: boolean;
+}
+
+/**
+ * Constructor options shared by all package manager commands.
+ */
+export interface CommandConstructorOptions {
+    pythonExecutable: string;
+    log?: LogOutputChannel;
+}
+
+/**
+ * Base class for all package manager commands.
+ * Provides common properties and minimal interface for subclasses.
+ */
+export abstract class PackageManagerCommand {
+    protected static readonly configSection?: string;
+
+    protected pythonExecutable: string;
+    protected log?: LogOutputChannel;
+    protected timeout: number = 300000;
+    protected config?: WorkspaceConfiguration;
+
+    constructor(options: CommandConstructorOptions) {
+        this.pythonExecutable = options.pythonExecutable;
+        this.log = options.log;
+        const configSection = (this.constructor as typeof PackageManagerCommand).configSection;
+        this.config = configSection ? getConfiguration(`python-envs.packageManager.${configSection}`) : undefined;
+    }
+
+    /**
+     * Executes this command and optionally wraps execution with a progress indicator.
+     */
+    public executeWithProgress<T = unknown, A extends BaseExecuteArgs = BaseExecuteArgs>(
+        executeArgs?: A,
+        title?: string,
+    ): Promise<T> {
+        if (!executeArgs?.showProgress) {
+            return this.execute(executeArgs) as Promise<T>;
+        }
+
+        return Promise.resolve(
+            window.withProgress(
+                {
+                    location: ProgressLocation.Notification,
+                    title: title ?? l10n.t('Running package manager command'),
+                    cancellable: true,
+                },
+                (_progress, token) =>
+                    this.execute({
+                        ...executeArgs,
+                        cancellationToken: executeArgs.cancellationToken ?? token,
+                    }) as Promise<T>,
+            ),
+        );
+    }
+
+    /**
+     * Subclasses implement command execution.
+     */
+    abstract execute(executeArgs?: BaseExecuteArgs): Promise<unknown>;
+
+    /**
+     * Subclasses implement to build the command arguments.
+     */
+    protected abstract buildCommand(executeArgs: BaseExecuteArgs): string[];
+}

src/managers/base/commands/uninstall.ts

@@ -0,0 +1,20 @@
+import { BaseExecuteArgs, PackageManagerCommand } from './packageManagerCommand';
+
+/**
+ * Arguments for uninstall command execution (change per execution).
+ */
+export interface UninstallExecuteArgs extends BaseExecuteArgs {
+    packages: { packageName: string; version?: string }[];
+}
+
+/**
+ * Template class for uninstall commands.
+ * Subclasses implement concrete package-manager-specific logic.
+ */
+export abstract class UninstallCommand extends PackageManagerCommand {
+    protected static readonly configSection = 'uninstallCommandArgs';
+
+    protected abstract buildCommand(executeArgs: UninstallExecuteArgs): string[];
+
+    abstract execute(executeArgs: UninstallExecuteArgs): Promise<void>;
+}

src/managers/base/commands/version.ts

@@ -0,0 +1,12 @@
+import type { Pep440Version } from '@renovatebot/pep440';
+import { BaseExecuteArgs, PackageManagerCommand } from './packageManagerCommand';
+
+/**
+ * Template class for version commands.
+ * Subclasses implement concrete package-manager-specific logic.
+ */
+export abstract class VersionCommand extends PackageManagerCommand {
+    protected static readonly configSection = 'versionCommandArgs';
+
+    abstract execute(executeArgs?: BaseExecuteArgs): Promise<Pep440Version | undefined>;
+}