Clear the current line when activating in terminal#1462
Open
Clear the current line when activating in terminal#1462
Conversation
Ensures that the current terminal line is cleared before the command for activation is passed to the terminal. Before, it would interrupt user input, resulting in corrupted commands like: git pu<activation command>\\n, which not only produces the wrong command, but can lead to unsafe execution. This occurs on the legacy (de)activation, due to users: - Having setting erminal.integrated.shellIntegration.enabled = false - Using a shell that does not support shell integration - Using slower machines, or remote SSH, and the shell integration timeout elapsing before the handshake.
edvilme
force-pushed
the
terminal-activation-clear-line
branch
from
1e91f4f to
2ab9f20
Compare
Contributor
Author
|
Ref #1375 |
Contributor
Author
|
Would be superseded by #962 but this consider the case for using the legacy activation |
Member
|
going to defer this to @anthonykim1 to make a decision since this is his area of expertise. I am inclined to say we hold on this as we get the terminal experiments out and the stuff anthony has been working on since that should address the same problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the current terminal line is cleared before the command for activation is passed to the terminal. Before, it would interrupt user input, resulting in corrupted commands like: git pu\n, which not only produces the wrong command, but can lead to unsafe execution.
This occurs on the legacy (de)activation, due to users: