Use configured NuGet source for analyzer tests - #1657
Open
Andrew Arnott (AArnott) wants to merge 2 commits into
Open
Use configured NuGet source for analyzer tests#1657Andrew Arnott (AArnott) wants to merge 2 commits into
Andrew Arnott (AArnott) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d82770a-b36c-40a8-95a6-4f807773da09
There was a problem hiding this comment.
Pull request overview
Updates analyzer tests to use repository-configured NuGet sources for reference assembly restoration.
Changes:
- Centralizes .NET 8 and .NET Framework 2.0 reference configurations.
- Replaces direct framework reference overrides in analyzer tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Microsoft.VisualStudio.Threading.Analyzers.Tests/VSTHRD104OfferAsyncOptionAnalyzerTests.cs | Updated as part of this pull request. |
| test/Microsoft.VisualStudio.Threading.Analyzers.Tests/VSTHRD103UseAsyncOptionAnalyzerTests.cs | Updated as part of this pull request. |
| test/Microsoft.VisualStudio.Threading.Analyzers.Tests/VSTHRD002UseJtfRunAnalyzerTests.cs | Updated as part of this pull request. |
| test/Microsoft.VisualStudio.Threading.Analyzers.Tests/Helpers/ReferencesHelper.cs | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d82770a-b36c-40a8-95a6-4f807773da09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isolated DevDiv pipeline fails because analyzer tests that override their reference assemblies bypass the repository's NuGet configuration and attempt to contact nuget.org directly.
This centralizes the .NET 8 and .NET Framework 2.0 reference assembly configurations in
ReferencesHelper, preserving each test's intended framework while routing package resolution through the authenticatedmsft_consumption_publicfeed. All explicit reference assembly overrides now use these isolation-safe configurations.The analyzer test project passes across net8.0, net8.0-windows, and net472 with 1,869 tests passed and 27 skipped.