Stabilize AsyncLazy value factory collection test - #1656
Open
Andrew Arnott (AArnott) wants to merge 2 commits into
Open
Stabilize AsyncLazy value factory collection test#1656Andrew Arnott (AArnott) wants to merge 2 commits into
Andrew Arnott (AArnott) wants to merge 2 commits into
Conversation
Remove the async helper state machine from the GC-sensitive test and keep the AsyncLazy rooted while verifying that its completed value factory is released. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 48b3b634-f1dc-4956-9b85-9ecd24ede8ac
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the AsyncLazy value-factory release test by avoiding compiler-generated closure retention.
Changes:
- Uses a dedicated factory object.
- Adds a synchronous, non-inlined helper.
- Keeps
AsyncLazyrooted during GC assertions.
Review noted a minor XML documentation nit for the new internal helper.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 48b3b634-f1dc-4956-9b85-9ecd24ede8ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueFactoryReleasedAfterExecutionintermittently fails on Linux because its async helper can retain the tested closure through compiler-generated state, producing a false-positive leak result.Replace the closure and async helper with a dedicated factory object behind a non-async, non-inlined boundary. Keep the
AsyncLazyrooted through the assertion so the test specifically verifies that a completed lazy releases its value factory.