Upgrade dependencies [skip chg] - #11961
Timothee Guerin (timotheeguerin) merged 8 commits into
Conversation
commit: |
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
There was a problem hiding this comment.
🟡 Changes recommended
Add the required dependency changesets and address or document the VS Code compatibility break.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Upgrades workspace dependencies and updates OpenAPI, Alloy, HTTP client, and VS Code configuration.
Changes:
- Updates dependency catalogs, overrides, and package dependencies.
- Migrates OpenAPI types to
@scalar/types. - Refreshes build settings, VS Code compatibility, notices, and Alloy tooling.
File summaries
| File | Summary |
|---|---|
pnpm-workspace.yaml |
Updates dependency catalog versions and overrides. |
packages/typespec-vscode/ThirdPartyNotices.txt |
Refreshes third-party notices. |
packages/typespec-vscode/package.json |
Updates VS Code engine and typings. |
packages/openapi3/src/cli/actions/convert/convert.ts |
Uses the updated Scalar type import. |
packages/openapi3/package.json |
Adds @scalar/types. |
packages/http-client/tsconfig.json |
Enables declaration-only output. |
packages/http-client/src/components/index.ts |
Updates the generated module import extension. |
packages/emitter-framework/package.json |
Adds the Alloy C# tooling dependency. |
Review details
Suppressed comments (1)
packages/openapi3/package.json:68
- Please add a
.chronusentry withchangeKind: dependenciesfor@typespec/openapi3(and the other published packages whose catalog ranges changed). This adds a new runtime dependency here, but no dependency changeset is included;.chronus/config.yaml:14-17and existing dependency entries require affected packages to be listed.
"@scalar/types": "catalog:",
- Files reviewed: 8/9 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the Node engine mismatch, document the VS Code compatibility break, and add the required changesets.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (3)
packages/typespec-vscode/package.json:30
- This raises the extension's minimum VS Code version from 1.125 to 1.136, so users on 1.125–1.135 can no longer install or update the extension. Because this is a user-visible compatibility break rather than only a type dependency bump, it needs an explicit breaking changelog entry (or the engine floor should remain at the previous supported version).
"vscode": "^1.136.0"
pnpm-workspace.yaml:38
@babel/core@8.0.1also requires^22.18.0 || >=24.11.0, while the packages that consume this catalog entry still declare Node>=22.0.0(for examplepackages/playground/package.json:53-54), and root installs are engine-strict. A contributor using Node 22.0–22.17 will therefore fail a normal workspace install; either retain a compatible Babel version for these tools or update the Node floor and CI matrix together.
"@babel/core": ^8.0.1
pnpm-workspace.yaml:25
- This dependency catalog bump affects published workspace packages, but the PR adds no
.chronusentry. The repository defineschangeKind: dependenciesfor dependency bumps (.chronus/config.yaml:14-17) and existing entries enumerate the affected packages, so please add the required changeset(s) with the exact package list rather than relying on[skip chg].
"@alloy-js/cli": ^0.25.0
"@alloy-js/core": ^0.25.0
"@alloy-js/csharp": ^0.25.0
- Files reviewed: 11/12 changed files
- Comments generated: 1
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
Two moderate compatibility issues must be addressed before approval.
Review details
Suppressed comments (2)
packages/typespec-vscode/package.json:30
- This raises the extension's runtime minimum from VS Code 1.125 to 1.136 even though the PR only updates the development-time
@types/vscodepackage and introduces no corresponding runtime API usage. Users on 1.125–1.135 will now be prevented from installing the extension; keep the existing engine floor unless the drop is required, or document and release this compatibility break instead of silently shipping it with[skip chg].
"vscode": "^1.136.0"
pnpm-workspace.yaml:38
@babel/code-frame@8.0.0declaresnode: ^22.18.0 || >=24.11.0(see the resolved package metadata inpnpm-lock.yaml:3327-3329), but@typespec/compilerstill advertisesnode: >=22.0.0(packages/compiler/package.json:75-76) and consumes this catalog entry as a runtime dependency. This silently drops Node 22.0–22.17 support; keep the Node-22-compatible Babel version or update the compiler engine/support policy and release it as a breaking change.
"@babel/code-frame": ^8.0.0
"@babel/core": ^8.0.1
- Files reviewed: 11/12 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
You can try these changes here
|
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
September dependency refresh for the monorepo, plus the matching `core`
bump.
Notable major bumps in the catalog:
| | |
|---|---|
| Vitest / `@vitest/*` | 4.x → 5.0.0 |
| Babel (`@babel/core`, `code-frame`) | 7.x → 8.x |
| Alloy (`@alloy-js/*`) | 0.24 → 0.25 (`python` 0.5 → 0.6,
`rollup-plugin` 0.1 → 0.2) |
| `@docsearch/*` | 4.7 → 5.0 |
| `@astrojs/starlight` | 0.41 → 0.42 |
| `@scalar/openapi-parser` | 0.28 → 0.29 |
| `web-tree-sitter` | 0.26 → 0.27 |
Also drops an obsolete `packageExtensions` workaround in `core` that
pinned the alloy toolchain to Babel 7:
```yaml
"@alloy-js/rollup-plugin":
dependencies:
"@babel/core": ^7.29.0
```
`@alloy-js/rollup-plugin@0.1.2` shipped
`@babel/preset-typescript@7.29.7`; `0.2.0` ships `8.0.1`, whose peer is
`@babel/core: ^8.0.0`. With the catalog now on Babel 8 the pin was
inverted — holding the toolchain on the version it was written to avoid.
Removed in microsoft/typespec#11961; verified by running the packages
whose `vitest.config.ts` uses `alloyPlugin()` (emitter-framework 407
tests, graphql 368, tspd 102) plus `alloy build`, all green with no peer
warnings.
Depends on microsoft/typespec#11961 — the `core` pointer here references
that branch and needs a re-point to `main` once it merges.
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
No description provided.