Bump C# TCGC to 0.72.0 and regenerate clients - #11928
Jorge Rangel (jorgerangel-msft) with Copilot wants to merge 3 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
| "@typespec/streams": ">=0.85.0 <0.86.0 || ~0.86.0-0", | ||
| "@typespec/versioning": ">=0.85.0 <0.86.0 || ~0.86.0-0" | ||
| "@azure-tools/typespec-azure-core": "^0.72.0", | ||
| "@azure-tools/typespec-client-generator-core": "^0.72.0", |
There was a problem hiding this comment.
Copilot we should not use ^ for dependencies that previously had a range. We should maintain the previous versioning range pattern for all dependencies that had it.
There was a problem hiding this comment.
Restored the original >=current <next || ~next-0 pattern for all seven affected peer dependencies and synchronized the lockfile in feb67e8. Dependencies that already used ^ remain unchanged. No resolved versions changed; the build and all 56 focused tests passed.
| ) | ||
| $emitterDir = Resolve-Path (Join-Path $PSScriptRoot '..' '..') | ||
| $command = "npx tsp compile $specFile" | ||
| $customizationFile = Join-Path $generationDir "client.tsp" |
There was a problem hiding this comment.
The pinned @typespec/http-specs@0.1.0-alpha.42 contains both Streaming.Sse.Unnamed.Info and Streaming.Sse.Protocol.Info. Regeneration overwrites Info.cs and produces duplicate model-factory signatures, breaking the build. This hook loads the scenario-local customization that renames only the new model to ProtocolInfo, preserving the existing API in both generation and Spector tests. Once we consume a published spec package containing #11920, this customization and hook can be removed.
| strictEqual(bodyType.crossLanguageDefinitionId, "TypeSpec.Http.File"); | ||
| strictEqual(bodyType.isFileType, true); | ||
|
|
||
| const contentTypeParam = method.operation.parameters.find((p) => p.name === "contentType"); |
There was a problem hiding this comment.
These assertions cover the file-upload fix shipped in TCGC 0.72.0 (Azure/typespec-azure#5306): an unspecified content type becomes an optional string defaulting to application/octet-stream. They failed on 0.71.2 (constant instead of string) and pass on 0.72.0. They aren't required to perform the bump; they're focused regression coverage confirming that the C# emitter preserves the new behavior.
commit: |
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Upgrade
http-client-csharpto TCGC 0.72.0 and compatible dependencies, regenerate client baselines, and verify existing tests.client.tspimports to rename the new SSEInfomodel toProtocolInfo, avoiding generated file and factory collisions while preserving existing APIs.application/octet-stream.Generate.ps1completed; 240 emitter tests, 4,176 generator/local tests, and 3 SSE integration tests passed. Existing skips unchanged.