Skip to content

Remove obsolete transitive NuGet overrides from typespec-vs#10824

Merged
timotheeguerin merged 5 commits into
mainfrom
copilot/remove-unnecessary-nuget-package
Jun 1, 2026
Merged

Remove obsolete transitive NuGet overrides from typespec-vs#10824
timotheeguerin merged 5 commits into
mainfrom
copilot/remove-unnecessary-nuget-package

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 28, 2026

The Visual Studio extension was carrying explicit NuGet references that were only needed to suppress older transitive vulnerability and NU1603 issues. Those overrides are no longer necessary with the currently resolved Visual Studio package set.

  • Dependency cleanup

    • Remove explicit PackageReferences for:
      • MessagePack
      • Microsoft.VisualStudio.Composition
      • Microsoft.VisualStudio.Shell.15.0
  • Project file simplification

    • Drop the associated explanatory/TODO comments tied to those temporary overrides.
    • Keep the direct Visual Studio SDK/workspace dependencies unchanged so the extension continues to pick up these packages transitively.
  • Result

    • typespec-vs now relies on the Visual Studio packages to supply these dependencies instead of pinning them redundantly in the project file.
<!-- removed -->
<PackageReference Include="MessagePack" Version="2.5.192" />
<PackageReference Include="Microsoft.VisualStudio.Composition" Version="17.13.41" />
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" Version="17.14.40264" />

Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added the ide Issues for VS, VSCode, Monaco, etc. label May 28, 2026
Copilot AI changed the title [WIP] Remove unnecessary nuget package in vs-extension Remove obsolete transitive NuGet overrides from typespec-vs May 28, 2026
Copilot AI requested a review from timotheeguerin May 28, 2026 12:36
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 28, 2026

Open in StackBlitz

npm i https://pkg.pr.new/typespec-vs@10824

commit: fc0d818

@timotheeguerin
Copy link
Copy Markdown
Member

@copilot add changelog

Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 28, 2026

@copilot add changelog

Addressed in 4d6e325.

Comment thread packages/typespec-vs/CHANGELOG.md Outdated
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • typespec-vs
Show changes

typespec-vs - fix ✏️

Remove obsolete explicit Visual Studio transitive NuGet package overrides.

Comment thread packages/typespec-vs/src/Microsoft.TypeSpec.VS.csproj
@timotheeguerin timotheeguerin added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 5fe4957 Jun 1, 2026
30 checks passed
@timotheeguerin timotheeguerin deleted the copilot/remove-unnecessary-nuget-package branch June 1, 2026 13:01
@timotheeguerin
Copy link
Copy Markdown
Member

timotheeguerin commented Jun 1, 2026

hhm it did actually cause issue, looks like we are not testing the VS build correctly in the CI, will have a separate PR fixing it

ing projects to restore...
D:\a\_work\1\s\packages\typespec-vs\src\Microsoft.TypeSpec.VS.csproj : error NU1603: Warning As Error: Microsoft.VisualStudio.Workspace 17.12.19 depends on Microsoft.VisualStudio.Composition (>= 17.10.39) but Microsoft.VisualStudio.Composition 17.10.39 was not found. An approximate best match of Microsoft.VisualStudio.Composition 17.11.13 was resolved. [D:\a\_work\1\s\packages\typespec-vs\Microsoft.TypeSpec.VS.sln]
D:\a\_work\1\s\packages\typespec-vs\src\Microsoft.TypeSpec.VS.csproj : error NU1603: Warning As Error: Microsoft.VisualStudio.Workspace.VSIntegration 17.12.19 depends on Microsoft.VisualStudio.Shell.15.0 (>= 17.10.40224) but Microsoft.VisualStudio.Shell.15.0 17.10.40224 was not found. An approximate best match of Microsoft.VisualStudio.Shell.15.0 17.11.40262 was resolved. [D:\a\_work\1\s\packages\typespec-vs\Microsoft.TypeSpec.VS.sln]
  Failed to restore D:\a\_work\1\s\packages\typespec-vs\src\Microsoft.TypeSpec.VS.csproj (in 26.04 sec).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ide Issues for VS, VSCode, Monaco, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary nuget package in vs-extension

3 participants