Add a parentWatchdogEnabled CLI flag - #4808
Open
mj026 wants to merge 1 commit into
Open
Conversation
Member
|
Why? Parent watching is in the spec. Can you explain your needs? |
Member
|
Ah, PR first, issue second... |
Contributor
There was a problem hiding this comment.
🟡 Not ready to approve
The changed composite-literal line is not gofmt-formatted and will fail formatting checks.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Adds a CLI option to disable the LSP parent-process watchdog.
Changes:
- Adds
--parentWatchdogEnabled. - Skips watchdog setup when disabled.
File summaries
| File | Description |
|---|---|
cmd/tsgo/lsp.go |
Adds and applies the watchdog flag. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| }, | ||
| ProgressDelay: 250 * time.Millisecond, | ||
| SetParentProcessID: newParentProcessWatchdog(ctx, stop), | ||
| SetParentProcessID: newParentProcessWatchdog(ctx, stop, *watchdogEnabled), |
Author
|
You're fast with replying 🚀 😎. The parent process detection is sometimes not accurate. I described the issue in #4809. |
So we can manually disable the watchdog when needed.
mj026
force-pushed
the
feature/watchdog-enabled-flag
branch
from
July 31, 2026 18:07
98bcc06 to
399de2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can disable the watchdog with the CLI when desired.