Skip to content

Revert WinUI sample PackagedApp reference until packaged-app launch is supported #9913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Evangelink wants to merge 1 commit into from
+0 −18
Closed

Revert WinUI sample PackagedApp reference until packaged-app launch is supported #9913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions samples/public/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@
<MSTestEngineVersion>$(MSTestAOTVersion)</MSTestEngineVersion>
<PlaywrightVersion>1.61.0</PlaywrightVersion>
<TestingPlatformVersion>2.3.2</TestingPlatformVersion>
<!--
Microsoft.Testing.Extensions.PackagedApp is the experimental extension that deploys and launches
a packaged Windows (UWP/WinUI) test host. It versions independently from the 2.x testing platform
(it ships as a 1.0.0-alpha.* build), which is why it has its own property here.
-->
<MicrosoftTestingExtensionsPackagedAppVersion>1.0.0-alpha.26363.8</MicrosoftTestingExtensionsPackagedAppVersion>
<VSTestVersion>18.7.0</VSTestVersion>
<GenerateDocumentationFile>false</GenerateDocumentationFile>
<NoWarn>$(NoWarn);SA0001;EnableGenerateDocumentationFile</NoWarn>
Expand Down
7 changes: 0 additions & 7 deletions samples/public/mstest-runner/MSTestRunnerWinUI/MSTestRunnerWinUI/MSTestRunnerWinUI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,6 @@
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.26100.7175" />
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.8.251106002" />
<PackageReference Include="MSTest" Version="$(MSTestVersion)" />
<!--
Deploy and launch the packaged WinUI test host through Microsoft.Testing.Platform's ITestHostLauncher
extension point. Referencing the package is enough: its MSBuild props register the launcher through the
SelfRegisteredExtensions that this app already calls in UnitTestApp.OnLaunched (do NOT also call
AddPackagedAppDeployment() explicitly, as only one test host launcher may be registered). MTP-only.
-->
<PackageReference Include="Microsoft.Testing.Extensions.PackagedApp" Version="$(MicrosoftTestingExtensionsPackagedAppVersion)" Condition=" '$(EnableMSTestRunner)' == 'true' " />
</ItemGroup>

<!--
Expand Down
5 changes: 0 additions & 5 deletions samples/public/mstest-runner/MSTestRunnerWinUI/MSTestRunnerWinUI/UnitTestApp.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,6 @@ void OnLaunched(Microsoft.UI.Xaml.LaunchActivatedEventArgs args)
.Where(arg => !arg.Contains("EnableMSTestRunner"))
.ToArray();
ITestApplicationBuilder builder = await TestApplication.CreateBuilderAsync(cliArgs);

// Registers all MSBuild-contributed extensions, including the Microsoft.Testing.Extensions.PackagedApp
// launcher (from the PackageReference in the csproj). That launcher deploys this packaged WinUI test
// host into an isolated directory and launches it from there through the platform's ITestHostLauncher
// extension point.
builder.AddSelfRegisteredExtensions(cliArgs);
using ITestApplication app = await builder.BuildAsync();
await app.RunAsync();
Expand Down