feat!: Optimize JSON key deserialization with arena-based interning - #490
Open
Anand Krishnamoorthi (anakrish) wants to merge 1 commit into
Open
feat!: Optimize JSON key deserialization with arena-based interning#490Anand Krishnamoorthi (anakrish) wants to merge 1 commit into
Anand Krishnamoorthi (anakrish) wants to merge 1 commit into
Conversation
Anand Krishnamoorthi (anakrish)
commented
Oct 27, 2025
Anand Krishnamoorthi (anakrish)
commented
Collaborator
- Add KeyArena in src/string.rs for per-document string deduplication
- Refactor Value deserialization to intern object keys via ValueSeed
- Ensure no_std compatibility with hashbrown + FxHasher
- Add unit test confirming Rc reuse across deserialized objects
- Update Cargo.toml with hashbrown and rustc-hash dependencies
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Anand Krishnamoorthi (anakrish)
force-pushed
the
object-opt
branch
5 times, most recently
from
October 28, 2025 15:22
13c455c to
65e36e5
Compare
Anand Krishnamoorthi (anakrish)
marked this pull request as ready for review
October 28, 2025 15:50
Anand Krishnamoorthi (anakrish)
force-pushed
the
object-opt
branch
from
October 28, 2025 21:28
65e36e5 to
ccba04d
Compare
Anand Krishnamoorthi (anakrish)
force-pushed
the
object-opt
branch
4 times, most recently
from
October 29, 2025 08:57
e82b958 to
1ce3c1f
Compare
- Add KeyArena in src/string.rs for per-document string deduplication - Refactor Value deserialization to intern object keys via ValueSeed - Ensure no_std compatibility with hashbrown + FxHasher - Add unit test confirming Rc<str> reuse across deserialized objects - Update Cargo.toml with hashbrown and rustc-hash dependencies Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
Anand Krishnamoorthi (anakrish)
force-pushed
the
object-opt
branch
from
October 29, 2025 09:04
1ce3c1f to
210f22e
Compare
Denis Komissarov (dekomissMSFT)
approved these changes
Nov 15, 2025
Denis Komissarov (dekomissMSFT)
left a comment
Denis Komissarov (dekomissMSFT)
left a comment
Collaborator
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.