Integrate RN Nightly Build 0.85.0-nightly-20260128-36f07a1b2#16217
Open
anuagragith wants to merge 6 commits into
Open
Integrate RN Nightly Build 0.85.0-nightly-20260128-36f07a1b2#16217anuagragith wants to merge 6 commits into
anuagragith wants to merge 6 commits into
Conversation
Resolved 14 files with conflicts from the RN 0.85.0-nightly-20260128 integration: packages/ (10 files): - monorepo/package.json, tester/package.json: kept nightly versions - AccessibilityInfo.win32.js: upstream keyof + Win32 platform branch - TextInput.flow.win32.js: upstream ReadonlyArray + Win32 accessibility props - Touchable.win32.js: upstream ReadonlyArray + Win32 keyboard/mouse props - CoreEventTypes.win32.js: upstream ReadonlyArray + Win32 ctrlKey - RNTesterExampleFilter.win32.js: upstream ReadonlyArray + Win32 bookmarks - TextExample.windows.js: upstream FiraCode examples + Windows view close - TextSharedExamples.windows.js: kept RNW override pattern - Text.win32.js: major refactor - removed legacy TextImplLegacy branch, removed ReactNativeFeatureFlags checks, adopted processedProps pattern, preserved all Win32 accessibility additions vnext/ (4 files): - AccessibilityInfo.windows.js: upstream keyof + Windows platform branch - TextInput.flow.windows.js: upstream ReadonlyArray + Windows props - Touchable.windows.js: upstream ReadonlyArray + Windows touch props - Text.windows.js: same major refactor as win32 variant with Windows accessibility props (aria-level, aria-readonly, etc.) All files pass node --check and Metro bundle succeeds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- ReactCommon.vcxproj: Suppress C4267 warning in upstream MapBuffer.cpp (size_t to int32_t conversion, warnings-as-errors) - ImageComponentView.cpp: Adapt to upstream API change where addObserver/removeObserver now take shared_ptr instead of raw reference Linker errors (AnimationBackend) remain to be addressed in next iteration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add new upstream animationbackend module source files to ReactCommon.vcxproj: - AnimatedPropSerializer.cpp - AnimatedPropsRegistry.cpp - AnimationBackend.cpp - AnimationBackendCommitHook.cpp Create Windows-patched AnimatedPropSerializer.cpp in TEMP_UntilReactCommonUpdate to handle platform Color struct (not int32_t on Windows) with colorToInt32() helper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Performance Test ResultsBranch: ✅ Passed161 scenario(s) across 28 suite(s) — no regressionsSectionList
FlatList
TouchableOpacity
ScrollView
TouchableHighlight
Pressable
Modal
Image
ActivityIndicator
Switch
Button
TextInput
View
Text
SectionList.native-perf-test.ts
FlatList.native-perf-test.ts
TouchableHighlight.native-perf-test.ts
TouchableOpacity.native-perf-test.ts
Pressable.native-perf-test.ts
ScrollView.native-perf-test.ts
ActivityIndicator.native-perf-test.ts
TextInput.native-perf-test.ts
Switch.native-perf-test.ts
Button.native-perf-test.ts
Modal.native-perf-test.ts
Image.native-perf-test.ts
View.native-perf-test.ts
Text.native-perf-test.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrate RN Nightly Build 0.85.0-nightly-20260128-36f07a1b2 - This PR integrates React Native Windows with a newer upstream React Native nightly build (Jan 28, 2026), advancing from the previous checkpoint of Jan 14, 2026. RNW is currently several months behind the latest RN nightly, so we are catching up in +14 day increments. This is the first PR in a series of catch-up integrations to bring RNW back to parity with the latest RN nightlies.
Please note:
This is my first attempt at RN → RNW integration. I used the integration script as a starting point and leveraged AI to help resolve merge conflicts, build issues, and linker errors, while reviewing and validating the resulting changes throughout the process.
In addition to ensuring the solution builds successfully, I validated the Playground app, including most controls and scenarios. Paid particular attention to the Text page, which had significant merge conflicts, and everything appears to be functioning correctly based on my testing.
Given the scope of the changes and the amount of conflict resolution involved, I'd appreciate a thorough review - especially for packages/@office-iss/react-native-win32/src-win/Libraries/Text/Text.win32.js to help catch anything that may have been inadvertently missed. Adding multiple reviewers to provide broader coverage across the different areas impacted by this integration. Thank you for taking a look.
Integration Details:
Commit range: facebook/react-native@f15985f...36f07a1
Type of Change
Why
Staying current with upstream ensures we pick up bug fixes, API changes, and performance improvements from core React Native, and reduces the risk of large, painful integrations later.
What
Integrate RN Nightly Build 0.85.0-nightly-20260128-36f07a1b2
Screenshots
N/A
Testing
Javascript validation:
⚠️ Flow — Version mismatch (pre-existing): config requires ^0.298.0, installed version is 0.296.1
✅ yarn build (lage monorepo) — All packages pass
✅ yarn lint (ESLint) — 0 errors (21 pre-existing warnings)
✅ node --check on all resolved files — No syntax errors
✅ No conflict markers in repo — Confirmed via grep
✅ Metro bundle loads successfully — JS bundle served at localhost:8081
Native Build Validation:
✅ NuGet restore — Passed
✅ ReactCommon.vcxproj compile — Passed
Included MapBuffer C4267 suppression
Included AnimationBackend source files
✅ Microsoft.ReactNative.vcxproj compile — Passed
✅ Microsoft.ReactNative.vcxproj link — Passed
AnimationBackend symbols resolved successfully
✅ Playground-Composition.vcxproj compile — Passed
✅ Full solution build — Build succeeded
Playground App Validation:
✅ App launch (playground-composition) — Successful
✅ Metro bundler — Serving JavaScript correctly
✅ File → Open JavaScript File → RNTester samples — Loads successfully
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow